Refactoring controllers#238
Merged
LucasSlunt merged 12 commits intomainfrom Mar 29, 2025
Merged
Conversation
… the correct file.
… frontend test js file route mappings and moving to correct test files.
…le endpoints. Fixed some formatting and minor issues in controllers and controller tests, as well as frontend api class.
LucasSlunt
approved these changes
Mar 29, 2025
Owner
LucasSlunt
left a comment
LucasSlunt
left a comment
There was a problem hiding this comment.
All backend and frontend tests pass, maven builds without failure. Refactors look great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the backend controllers to be better separated with what the API endpoint does.
Changed routings so they all begin with /api, and minor changes to the other routings
ENSURE ALL BACKEND AND FRONTEND TESTS ARE PASSING BEFORE MERGING, a big change like this can easily break the main branch.