Try fix async TU #48
Merged
Try fix async TU #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=========================================
Coverage ? 27.54%
=========================================
Files ? 27
Lines ? 1532
Branches ? 168
=========================================
Hits ? 422
Misses ? 1092
Partials ? 18Continue to review full report at Codecov.
|
nfaugout-lucca
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue specific to net461 target, reported in xunit/xunit#789 (comment)
Net461 suffers a synchronisationContext issue on CultureInfo.CurrentCulture, preventing CurrentCulture flow along aync calls, in certain specific cases.
This is a real blocker for net461.
Also tried net471, same beahvior.
No complete workaround as for now, so I just bypass the unit test