[pull] forks/amsterdam from ethereum:forks/amsterdam#264
Merged
Conversation
* feat(tests): EIP-8037 code-deposit state gas exact-fit boundary Pin the code-deposit state gas charge at its exact-fit gas boundary. A CREATE transaction deploys code via RETURN(0, code_size); after the init code returns, code deposit charges keccak regular gas from gas_left then code_size * COST_PER_STATE_BYTE state gas, reservoir first and spilling into gas_left. test_code_deposit_state_gas_exact_fit_boundary sets the transaction gas so the deposit charge lands exactly at the available gas (the contract deploys) or one gas short (the deposit halts, NEW_ACCOUNT is refilled, and no code is deployed). The reservoir_funded case uses code_size = MAX_CODE_SIZE so the deposit exceeds the EIP-7825 cap and is drawn reservoir first (the shortfall reduces the reservoir; an over-cap halt bills exactly the cap); the gas_left_spill case uses an in-cap gas limit so the deposit spills wholly from gas_left. The scaling tests vary the size but assert success only, leaving this boundary unpinned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )