Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #4597 by correctly converting nullable types when using MapAtRuntime(). The issue occurred when mapping from a non-nullable value type (e.g., int from an extension method result) to a nullable destination property (e.g., int?) with MapAtRuntime enabled.
Changes:
- Added type conversion in
ContextMapto ensure source expressions match the expected generic type parameter - Added comprehensive test coverage for the nullable conversion scenario with extension methods
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/AutoMapper/Execution/ExpressionBuilder.cs | Adds ToType conversion to ensure source parameter type matches typePair.SourceType before calling MapInternal |
| src/UnitTests/Bug/MapAtRuntime/MapAtRuntimeWithExtensionMethodAndNullable.cs | Adds test class with two test methods covering both non-null and null source scenarios when mapping extension method results to nullable destinations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jbogard
deleted the
4597-mapatruntime-with-with-non-nullable-to-nullable-mapping-fails-when-extension-methods-are-used
branch
This was referenced Mar 4, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.