Replace all unwrap with better error handling#7
Merged
LuernOutOfOrder merged 2 commits intodevelopfrom Nov 4, 2025
Merged
Conversation
…needless_range_loop for needed loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving error handling and code robustness across several device initialization and FDT (Flattened Device Tree) helper functions. The main changes involve replacing
unwrap()calls with explicit error messages usingexpect(), which provides clearer diagnostics in case of failure. Additionally, some minor code style improvements and lint suppressions have been introduced for better code quality.Error handling improvements
unwrap()calls withexpect()and descriptive error messages in device initialization routines and FDT property accessors, improving diagnostics and preventing silent panics. (src/devices/mod.rs,src/devices/serials/ns16550.rs,src/dtb/helpers.rs,src/dtb/mod.rs) [1] [2] [3] [4] [5] [6] [7]Code style and linting
#[allow(clippy::needless_range_loop)]annotations to suppress Clippy lint warnings in loops where the range loop is intentional. (src/devices/serials/ns16550.rs,src/dtb/helpers.rs) [1] [2]Minor robustness improvements
print()to ignore formatting errors instead of panicking, making printing more robust. (src/print.rs)These changes collectively make the codebase safer and easier to debug by surfacing meaningful error messages and preventing unexpected panics.