Skip to content

Replace all unwrap with better error handling#7

Merged
LuernOutOfOrder merged 2 commits intodevelopfrom
1-replace-all-unwrap
Nov 4, 2025
Merged

Replace all unwrap with better error handling#7
LuernOutOfOrder merged 2 commits intodevelopfrom
1-replace-all-unwrap

Conversation

@LuernOutOfOrder
Copy link
Owner

This pull request focuses on improving error handling and code robustness across several device initialization and FDT (Flattened Device Tree) helper functions. The main changes involve replacing unwrap() calls with explicit error messages using expect(), which provides clearer diagnostics in case of failure. Additionally, some minor code style improvements and lint suppressions have been introduced for better code quality.

Error handling improvements

  • Replaced all unwrap() calls with expect() and descriptive error messages in device initialization routines and FDT property accessors, improving diagnostics and preventing silent panics. (src/devices/mod.rs, src/devices/serials/ns16550.rs, src/dtb/helpers.rs, src/dtb/mod.rs) [1] [2] [3] [4] [5] [6] [7]

Code style and linting

  • Added #[allow(clippy::needless_range_loop)] annotations to suppress Clippy lint warnings in loops where the range loop is intentional. (src/devices/serials/ns16550.rs, src/dtb/helpers.rs) [1] [2]

Minor robustness improvements

  • Changed error handling in print() to ignore formatting errors instead of panicking, making printing more robust. (src/print.rs)

These changes collectively make the codebase safer and easier to debug by surfacing meaningful error messages and preventing unexpected panics.

@LuernOutOfOrder LuernOutOfOrder self-assigned this Nov 4, 2025
@LuernOutOfOrder LuernOutOfOrder added the enhancement New feature or request label Nov 4, 2025
@LuernOutOfOrder LuernOutOfOrder merged commit 323261a into develop Nov 4, 2025
1 check passed
@LuernOutOfOrder LuernOutOfOrder deleted the 1-replace-all-unwrap branch November 4, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant