Skip to content

fix(security): avoid regex comment stripping for #366#367

Merged
Luis85 merged 1 commit into
mainfrom
fix/security-pr-366
May 8, 2026
Merged

fix(security): avoid regex comment stripping for #366#367
Luis85 merged 1 commit into
mainfrom
fix/security-pr-366

Conversation

@Luis85
Copy link
Copy Markdown
Owner

@Luis85 Luis85 commented May 8, 2026

Summary

Addresses the CodeQL security review surfaced on #366 without pushing directly to main.

  • replaces the HTML/CSS comment-stripping regex path in tests/scripts/sites-no-hex-literals.test.ts with delimiter scanning that preserves newlines
  • tightens the JS/TS line-comment regex so it does not consume newline characters
  • adds focused coverage for comment stripping and malformed nested HTML comment input

After this merges into main, PR #366 (main -> demo) will include the fix on its head branch.

Verification

  • npm run test:scripts -- tests/scripts/sites-no-hex-literals.test.ts
  • npm run typecheck:scripts
  • npm run verify

Related

@Luis85 Luis85 merged commit 7200144 into main May 8, 2026
8 checks passed
@Luis85 Luis85 deleted the fix/security-pr-366 branch May 8, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants