chore(build): silence rolldown vite:dts plugin-timings warning#125
Merged
Conversation
Every `npm run build` (including local pre-PR `npm run verify` and every CI run) printed: > [PLUGIN_TIMINGS] Warning: Your build spent significant time in > plugin `vite:dts`. See https://rolldown.rs/options/checks#plugintimings This is rolldown's heuristic flagging plugins that dominate build wall time. It is informational only — `vite-plugin-dts` ran in ~3.0s of a ~3.7s build (~80% of total) because it invokes the TypeScript compiler to emit declarations, which is intrinsically slow. Investigated whether the timing was actually reducible: - Already pinned to `vite-plugin-dts@4.5.4` (latest as of 2026-04-26). - `tsconfig.build.json` already excludes tests / specs / examples. - `skipLibCheck: true` is already inherited from the base `tsconfig.json`. - `rollupTypes: false` already keeps us off the slow bundle-types path. - `entryRoot: 'src'` already matches the actual source root. - `staticImport: true` is already on. There is no remaining lever. The plugin is genuinely the slowest phase by design, and the warning is just rolldown describing that fact. Suppress the check via `build.rollupOptions.checks.pluginTimings: false` so the warning stops cluttering build output and misleading future contributors into chasing a fix that doesn't exist. Inline comment in `vite.config.ts` records the investigation so the rationale is visible in-place. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
@codex review |
Coverage report
Floors live in |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
size-limit report 📦
|
3 tasks
Luis85
added a commit
that referenced
this pull request
Apr 26, 2026
## Summary
Doc-audit pass over `docs/plans` + `docs/specs`. Three things land
together:
- **`docs/archive/{plans,specs}/`** — new home for plans whose roadmap
rows have all shipped (or whose goals were folded into a successor)
and specs whose design is now reflected in code. Includes a
`README.md` explaining the policy; `CLAUDE.md` documents the
convention.
- **`git mv` 23 plans + 3 specs into the archive.** The active live
set is now the comprehensive polish-and-harden plan plus three
specs (post-tfjs improvements, mvp-demo, vision), each with a
refreshed status banner.
- **Refresh the live comprehensive plan** against current `develop`:
- PR column updated for rows 16/19/20/3/4/22 (now shipped via
PRs #91 / #98 / #104 / #110 / #113 / #111).
- New "Post-roadmap follow-ups" section covers PRs #92 → #125
(review-bot infra, tracker findings, demo + tfjs hotfixes,
tooling).
- Stale prose-baked counts dropped (size budgets now reference
`package.json#size-limit` only).
- Coverage-thresholds section gains a pointer to the sticky PR
comment shipped in PR #124.
## Other doc fixes
- `README.md`: drop the unverifiable "Phase A milestones (M0–M15) are
all green" claim — the milestones don't exist as documented IDs
anywhere; replace with a pointer to the live polish plan.
- `vision.md`: refresh cadence note (was pinned to 2026-04-19 + "next
review at 1.0").
- `2026-04-24-post-tfjs-improvements.md`: mark recommended-order items
that have shipped (PRs #61, #76, #77, #83, #84, #91, #94, #96,
#104, #113), link the active roadmap as the heir.
- `mvp-demo.md`: status banner explaining where active polish work is
now tracked.
## Mechanical
- Update inline cross-refs in `CLAUDE.md`, `eslint.config.js`,
`src/agent/{Agent,AgentModule}.ts`, `tests/unit/exports.test.ts`,
and `docs/daily-reviews/2026-04-25.md` to point at the new
`docs/archive/` paths so links keep resolving.
No code change beyond comment-path updates.
## Test plan
- [x] `npm run verify` green (`format:check` + `lint` + `typecheck` +
`test` + `build` + `docs`). 523 tests pass; the 2 lint warnings
are pre-existing (`CognitionPipeline.invokeSkillAction` complexity
+ `scoreFailure` param count) and on the ratchet menu.
- [x] `git ls-files docs/archive/` shows the moved files; renames are
preserved (`git log --follow` works for any moved file).
- [ ] Codex review: clean, no blockers.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Co-authored-by: Luis Mendez <hallo@luis-mendez.de>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every
npm run build(locally duringnpm run verifyand on everyCI run) prints:
This is rolldown's heuristic flagging plugins that dominate build
wall time. It is informational, not actionable —
vite-plugin-dtstakes ~3.0s of a ~3.7s build (~80%) because it invokes the
TypeScript compiler to emit declarations, which is intrinsically the
slow part of the build.
Investigation
Checked every lever before resorting to suppression:
vite-plugin-dts@4.5.4(latest as of 2026-04-26)tsconfig.build.jsonalready excludestests/,examples/,*.test.ts,*.spec.tsskipLibCheck: trueis already inherited from the basetsconfig.jsonrollupTypes: falsealready keeps us off the slow bundle-typespath
entryRoot: 'src'already matches the actual source rootstaticImport: truealready onNo remaining setting reduces
vite-plugin-dtsruntime. The warningis rolldown describing reality.
Fix
Suppress the rolldown check via
build.rollupOptions.checks.pluginTimings: false. Inline comment invite.config.tsrecords the investigation so the rationale isvisible in-place — no future contributor will spend time chasing a
fix that doesn't exist.
Test plan
npm run verify— all green; build output now ends cleanly at✓ built in 3.49swith no[PLUGIN_TIMINGS]warningperf cost — it just gates a stdout write)
@codex review