Skip to content

docs(plans): flip workflow to one PR per session#149

Merged
Luis85 merged 1 commit into
developfrom
docs/one-pr-per-session-workflow
Apr 26, 2026
Merged

docs(plans): flip workflow to one PR per session#149
Luis85 merged 1 commit into
developfrom
docs/one-pr-per-session-workflow

Conversation

@Luis85
Copy link
Copy Markdown
Owner

@Luis85 Luis85 commented Apr 26, 2026

Summary

  • Retire the "batch all PRs per session, sweep Codex review-by-review" pattern. Owner observation 2026-04-26: multi-PR sessions muddy context, degrade solution quality, and end up slower despite the apparent parallelism.
  • New rule: one PR per Claude session, end-to-end — implement → verify → push → ride Codex iteration to 👍 in the same session → merge → stop. Cross-session parallelism via separate agents / worktrees stays fine.
  • Two plan files updated to match the new rule.

Files changed

  • docs/plans/2026-04-25-comprehensive-polish-and-harden.md — rewrote the Workflow section + How to pick this up next session checklist; softened the Sequencing at a glance "parallel batches" blurb to read as cross-session parallelism.
  • docs/plans/2026-04-26-quality-automation-routines.md — clarified the one-PR-per-chunk rationale points at sessions / agents in parallel, not multiple PRs inside one session.

Test plan

  • npm run verify green locally (format:check + lint + typecheck + 588 tests + build + typedoc)
  • No src/** changes — docs-only
  • No changeset (per CLAUDE.md: docs/refactor/chore PRs skip changesets)

Notes for review

  • Memory-side companion updates (the actual rule, the rewritten PR-workflow memory, the cross-referenced index) landed in the user-private auto-memory store at C:\Users\lum\.claude\projects\D--Projects-agent-library\memory\ — those persist across Claude sessions but are outside the repo by design.
  • The repo-shared .claude/memory/ directory has an unrelated preexisting dirty file on develop (squash-merge default note in feedback_autonomous_merge_after_codex.md) that is deliberately not bundled here — separate concern, separate session.
  • Old archived plan docs/archive/plans/2026-04-24-polish-and-harden.md still references the retired batch workflow. Left untouched — it's history.

Retire the "batch all PRs in one session, sweep Codex review-by-
review" pattern. Owner observation 2026-04-26: cramming multiple PRs
into one session muddies context, degrades solution quality, and
nets out slower than expected.

New rule: each Claude session ships exactly one PR end-to-end —
implement, verify, push, ride Codex iteration to 👍 in the same
session, merge, stop. Cross-session parallelism via separate
agents/worktrees stays fine.

- 2026-04-25-comprehensive-polish-and-harden.md: rewrote the
  Workflow section, the "How to pick this up next session"
  checklist, and softened the parallel-batches sequencing blurb.
- 2026-04-26-quality-automation-routines.md: clarified the
  one-PR-per-chunk rationale points at sessions/agents in
  parallel, not multiple PRs in one session.

Memory updates landed in the user-private auto-memory store
(outside repo); MEMORY.md index there now leads with
feedback_one_pr_per_session.md.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Luis85 Luis85 merged commit 66932a5 into develop Apr 26, 2026
18 checks passed
@Luis85 Luis85 deleted the docs/one-pr-per-session-workflow branch April 26, 2026 20:02
Luis85 added a commit that referenced this pull request Apr 26, 2026
## Summary

Update `feedback_autonomous_merge_after_codex.md` to reflect two operational shifts already in practice:

- **Project switched to squash-merge** post-PR #119. Every PR from #133 onward lands as a squash commit (`<type>: <subject> (#NNN)`). Previous `gh pr merge <n> --merge --delete-branch` recipe returns `enablePullRequestAutoMerge` GraphQL error.
- **Post-squash topic branches need `-D`** for cleanup. The squash creates a NEW commit SHA, so the local topic branch is no longer an ancestor of develop and `git branch -d <topic>` fails.

Also documents the `--auto` flag for cases where `gh pr merge` is fired while required checks are still mid-run.

## Files changed

- `.claude/memory/feedback_autonomous_merge_after_codex.md` — `--merge` → `--squash`, `-d` → `-D`, plus the `--auto` note.

## Test plan

- [x] `npm run verify` green locally (format:check + lint + typecheck + 588 tests + build + typedoc)
- [x] No `src/**` changes — memory-doc only
- [x] No changeset (per `CLAUDE.md`: docs/refactor/chore PRs skip changesets)

## Notes for review

- This recipe was used end-to-end on PR #149 a few minutes before this PR — `--squash --delete-branch` with `--auto`-equivalent timing worked clean.
- Rule violation flagged: this is a second PR opened in the same Claude session as #149. Owner explicitly requested it after #149 landed; cited as override of the new one-PR-per-session rule for a trivial single-file memory doc update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants