Execute post-processing middlewares when a pre-processing middleware returns early or fails#398
Merged
LukeMathWalker merged 2 commits intomainfrom Dec 21, 2024
Merged
Conversation
Owner
Author
|
/ok-to-test sha=255da46 |
Owner
Author
|
/ok-to-test sha=88e1e17 |
Merged
LukeMathWalker
added a commit
that referenced
this pull request
Dec 21, 2024
## 🤖 New release * `pavex`: 0.1.62 -> 0.1.63 * `pavex_bp_schema`: 0.1.62 -> 0.1.63 * `pavex_reflection`: 0.1.62 -> 0.1.63 * `pavex_macros`: 0.1.62 -> 0.1.63 * `persist_if_changed`: 0.1.62 -> 0.1.63 * `pavex_tracing`: 0.1.62 -> 0.1.63 * `pavex_cli`: 0.1.62 -> 0.1.63 * `pavex_cli_deps`: 0.1.62 -> 0.1.63 * `pavex_miette`: 0.1.62 -> 0.1.63 * `pavexc_cli_client`: 0.1.62 -> 0.1.63 * `pavexc`: 0.1.62 -> 0.1.63 * `pavexc_rustdoc_types`: 0.1.62 -> 0.1.63 * `pavex_cli_client`: 0.1.62 -> 0.1.63 * `pavex_session`: 0.1.62 -> 0.1.63 * `pavex_session_memory_store`: 0.1.62 -> 0.1.63 * `pavex_session_sqlx`: 0.1.62 -> 0.1.63 * `pavexc_cli`: 0.1.62 -> 0.1.63 * `generate_from_path`: 0.1.62 -> 0.1.63 <details><summary><i><b>Changelog</b></i></summary><p> ## `pavex` <blockquote> ## [0.1.63](0.1.62...0.1.63) - 2024-12-21 ### Other - Disable workspace hack before a release - Execute post-processing middlewares when a pre-processing middleware returns early or fails ([#398](#398)) - Re-enable workspace hack after a release ([#397](#397)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: pavex-releaser[bot] <ci@pavex.dev> Co-authored-by: pavex-releaser[bot] <167640712+pavex-releaser[bot]@users.noreply.github.com> Co-authored-by: Luca Palmieri <20745048+LukeMathWalker@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an oversight.
Considering what post-processing middlewares are used for (e.g. logging response data, injecting headers, etc.) it's much more useful to have them being invoked rather than skipped when something fails on the way in.