allow for images in random order#140
Merged
gegu merged 1 commit intoLukeSkywalker92:developfrom Sep 12, 2020
call-me-matt:feature/random-order
Merged
allow for images in random order#140gegu merged 1 commit intoLukeSkywalker92:developfrom call-me-matt:feature/random-order
gegu merged 1 commit intoLukeSkywalker92:developfrom
call-me-matt:feature/random-order
Conversation
call-me-matt
commented
Jul 30, 2020
| currentImageIndex = images.length; | ||
| loadImage(true, 0); | ||
| currentImageIndex = 0; | ||
| loadImage(false, 0, true); |
Author
There was a problem hiding this comment.
please verify this is ok. Need to jump directly to a new picture, as the other logic won't work in random order.
Author
There was a problem hiding this comment.
I think it has the side-effect that when new pictures come in while in pause, the picture changes to the latest one? (To be investigated)
gegu
approved these changes
Sep 12, 2020
Collaborator
gegu
left a comment
gegu
left a comment
There was a problem hiding this comment.
I think the extension fits.
I merge it into the develop branch.
We had a problem that the master was before the develop branch, which I fixed.
In the future we should stick to the workflow, otherwise the merges will get complicated.
Author
|
Great! Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #133