fix: read block config from correct path#33
Merged
Conversation
The form nests the target block's config under target_block.config.block_config, but validate and submit read from target_block.config — returning the wrapper array (with block_config, context_mapping, no_config keys) instead of actual plugin configuration. Nothing persists.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the TargetBlockFormProcessor service and its corresponding unit tests to use a more specific form state key, ['target_block', 'config', 'block_config'], instead of the previous ['target_block', 'config']. This change affects both the validation and submission logic for target blocks. I have no feedback to provide.
|
🎉 This PR is included in version 1.6.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateTargetBlock()andsubmitTargetBlock()read from['target_block', 'config']which returns the entire form wrapper (containingblock_config,context_mapping,no_configkeys)['target_block', 'config', 'block_config']setConfiguration(), so nothing persists — reopening the form shows defaultsTest plan
vendor/bin/phpunit --debug -c web/core/phpunit.xml.dist web/modules/contrib/proxy_block/tests/src/Unit/TargetBlockFormProcessorTest.php— all 19 tests pass