fix(lep6): close Zee R3 foundation review findings#128
Merged
j-rafique merged 1 commit intoLEP-6-foundationfrom Apr 28, 2026
Merged
fix(lep6): close Zee R3 foundation review findings#128j-rafique merged 1 commit intoLEP-6-foundationfrom
j-rafique merged 1 commit intoLEP-6-foundationfrom
Conversation
Closes all 20 findings from Zee R3 on PR #117 review 4188900358 against post-R2 LEP-6-foundation tip 8748065: HIGH 3/3: - scan reporter pass stats across all result classes while honoring overturned failures - validate strong-recovery clean-pass count against base recovery count - extend retention/migration history to divergence and heal-deadline windows MEDIUM 3/3: - bound heal verifier count to 1..32 - tighten Class-A predicate so TIMEOUT on INDEX remains Class B/unscaled - use no-op reward distribution mock so action tests exercise fee-routing path LOW 14/14: - strict postpone threshold ordering - recover malformed heal-op counters without panic/reuse - MaxUint64-safe epoch scan helpers for reporter results and transcripts - genesis validation/import/export hardening for artifact counts, transcripts, and facts - explicit failed-heal marker errors and propagation - clean-epoch recovery for fresh reporters - cross-holder PASS bonus coverage across non-hash prior failures - strict artifact-count fallback with error on absent counts - app-level module-order pinning - migration-position closure in v1->v2 Implementation guide updated with R3 hardening notes and refreshed pre-release checklist items. Verification performed before commit: - go build ./... - go test ./x/audit/v1/types ./x/audit/v1/keeper ./x/audit/v1/module ./x/action/v1/types ./x/action/v1/keeper ./app - go test ./x/... - go test ./tests/integration/action ./tests/integration/audit - go test -tags=system ./tests/system/... - go test -tags=system_test -timeout=1800s -v . from tests/systemtests ok github.com/LumeraProtocol/lumera/tests/systemtests 1031.464s - git diff --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes all 20 findings from Zee R3 on PR #117 review 4188900358 against post-R2 LEP-6-foundation tip 8748065:
HIGH 3/3:
MEDIUM 3/3:
LOW 14/14:
Implementation guide updated with R3 hardening notes and refreshed pre-release checklist items.
Verification performed before commit: