Generic support for upgrades and for action module as v1.0.0#20
Merged
Generic support for upgrades and for action module as v1.0.0#20
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds generic upgrade support for the action module, preparing the codebase for v1.0.0 releases. Key changes include:
- Adding a consensus version constant in the action module types.
- Creating a new upgrade handler with initial genesis configuration for the action module.
- Updating the application startup to register the upgrade handler and configure the store loader.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| x/action/types/genesis.go | Added ConsensusVersion constant to support module version tracking. |
| app/upgrades/v1_0_0/upgrade.go | Introduced the v1.0.0 upgrade handler with genesis initialization and store upgrades. |
| app/app.go | Registered the upgrade handler and set up the store loader for v1.0.0. |
akobrin1
approved these changes
May 4, 2025
Contributor
akobrin1
left a comment
akobrin1
left a comment
There was a problem hiding this comment.
Should we use versioning for action module from the beginning? (https://docs.cosmos.network/main/build/architecture/adr-054-semver-compatible-modules) - like "/x/action/v1" instead of "x/action". That will make so much easier to maintain multiple versions of action module - in case we introduce some breaking changes like changing field names/types, params. etc.
j-rafique
approved these changes
May 5, 2025
mateeullahmalik
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added generic support for upgrades and for action module as v1.0.0