Skip to content

Burn unclaimed coins#22

Merged
a-ok123 merged 2 commits intomasterfrom
update/burn-unclaimed
May 11, 2025
Merged

Burn unclaimed coins#22
a-ok123 merged 2 commits intomasterfrom
update/burn-unclaimed

Conversation

@mateeullahmalik
Copy link
Copy Markdown
Contributor

No description provided.

@mateeullahmalik mateeullahmalik force-pushed the update/burn-unclaimed branch from 33686e2 to dbd9bc6 Compare May 9, 2025 11:04
@a-ok123 a-ok123 requested a review from Copilot May 11, 2025 03:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces functionality to burn unclaimed tokens once the claim period ends. Key changes include:

  • Adding a GetBalance method to the BankKeeper interface.
  • Adding new event attributes (end_time and burn_time) and an event type for burning unclaimed tokens.
  • Updating EndBlocker logic to burn any remaining tokens and disabling claims.
  • Updating test utilities and system tests to support the new burning behavior.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
x/claim/types/expected_keepers.go Added GetBalance to the BankKeeper interface.
x/claim/types/events.go Introduced new event attributes and event type for token burn events.
x/claim/keeper/abci.go Modified EndBlocker to burn unclaimed tokens and update claim state.
testutil/keeper/claim.go Added a mock implementation for GetBalance.
tests/systemtests/system.go Changed executable lookup to use the user's home directory.
tests/systemtests/claim_period_end_test.go Added system tests to verify token burning after claim period end.
Comments suppressed due to low confidence (2)

x/claim/types/events.go:11

  • [nitpick] Ensure that the relocation or redefinition of AttributeKeyEndTime is consistent with its usage across the codebase to avoid potential ambiguity.
AttributeKeyEndTime    = "end_time"

tests/systemtests/system.go:748

  • The new executable lookup mechanism relies on the user's home directory rather than system PATH resolution. Confirm that this approach is intended for all target environments.
homeDir, err := os.UserHomeDir()

Comment thread x/claim/keeper/abci.go
@a-ok123 a-ok123 self-requested a review May 11, 2025 05:28
@a-ok123 a-ok123 merged commit 41595d6 into master May 11, 2025
8 checks passed
@mateeullahmalik mateeullahmalik deleted the update/burn-unclaimed branch November 26, 2025 21:00
@roomote-v0 roomote-v0 Bot mentioned this pull request May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants