Conversation
33686e2 to
dbd9bc6
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces functionality to burn unclaimed tokens once the claim period ends. Key changes include:
- Adding a GetBalance method to the BankKeeper interface.
- Adding new event attributes (end_time and burn_time) and an event type for burning unclaimed tokens.
- Updating EndBlocker logic to burn any remaining tokens and disabling claims.
- Updating test utilities and system tests to support the new burning behavior.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| x/claim/types/expected_keepers.go | Added GetBalance to the BankKeeper interface. |
| x/claim/types/events.go | Introduced new event attributes and event type for token burn events. |
| x/claim/keeper/abci.go | Modified EndBlocker to burn unclaimed tokens and update claim state. |
| testutil/keeper/claim.go | Added a mock implementation for GetBalance. |
| tests/systemtests/system.go | Changed executable lookup to use the user's home directory. |
| tests/systemtests/claim_period_end_test.go | Added system tests to verify token burning after claim period end. |
Comments suppressed due to low confidence (2)
x/claim/types/events.go:11
- [nitpick] Ensure that the relocation or redefinition of AttributeKeyEndTime is consistent with its usage across the codebase to avoid potential ambiguity.
AttributeKeyEndTime = "end_time"
tests/systemtests/system.go:748
- The new executable lookup mechanism relies on the user's home directory rather than system PATH resolution. Confirm that this approach is intended for all target environments.
homeDir, err := os.UserHomeDir()
a-ok123
approved these changes
May 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.