Skip to content

hotfix: temporarily disable SDK/client complaint and storage challenge evidence submission#279

Merged
mateeullahmalik merged 3 commits intomasterfrom
hotfix/disable-audit-client-complaint-and-storage-challenge
Mar 25, 2026
Merged

hotfix: temporarily disable SDK/client complaint and storage challenge evidence submission#279
mateeullahmalik merged 3 commits intomasterfrom
hotfix/disable-audit-client-complaint-and-storage-challenge

Conversation

@mateeullahmalik
Copy link
Copy Markdown
Collaborator

Summary

Temporary incident-response mitigation to stop audit evidence submissions from supernode paths that can contribute risk during stabilization.

Changes

  • Disable SDK cascade client complaint evidence submission:
    • sdk/adapters/lumera/adapter.go
    • SubmitCascadeClientFailureEvidence(...) now logs and returns without broadcasting tx.
  • Disable storage challenge failure evidence submission:
    • supernode/storage_challenge/service.go
    • maybeSubmitEvidence(...) now logs and returns without broadcasting tx.

Validation

  • go test ./sdk/adapters/lumera ./sdk/task ./supernode/storage_challenge

Notes

  • This is intentional temporary mitigation per ops directive.
  • Re-enable should be done in a follow-up PR once chain-side determinism hardening and validation are fully complete.

…rage challenge

- disable SubmitCascadeClientFailureEvidence in SDK adapter (log + no-op)
- disable storage challenge failure evidence submission path (log + no-op)
- keep runtime behavior explicit with mitigation comments for incident-response rollback clarity
@roomote-v0
Copy link
Copy Markdown

roomote-v0 bot commented Mar 25, 2026

Rooviewer Clock   See task

Both previously flagged dead-code issues have been resolved by commenting out the if err != nil guards alongside the disabled SubmitEvidence calls. No new issues found.

  • adapter.go:424-426 -- dead if err != nil block after commented-out SubmitEvidence call; err is always nil at that point
  • service.go:619-621 -- same dead if err != nil pattern after commented-out SubmitEvidence call
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

roomote-v0[bot]
roomote-v0 bot previously approved these changes Mar 25, 2026
Per incident directive, preserve evidence construction/validation code and comment out only chain submission calls for:
- cascade client complaint evidence (SDK adapter)
- storage challenge failure evidence (storage challenge service)
@mateeullahmalik mateeullahmalik merged commit 19b87d2 into master Mar 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant