Conversation
mateeullahmalik
changed the title
mateeullahmalik
force-pushed
the
everlight-supernode-compat-plan
branch
from
3bfe9b5 to
dbcd72b
Compare
Latest commit (
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote-v0[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| hostReport.DiskUsagePercent = diskUsagePercent | ||
| } | ||
| if cascadeBytes, ok := s.cascadeKademliaDBBytes(tickCtx); ok { | ||
| hostReport.CascadeKademliaDbBytes = float64(cascadeBytes) |
There was a problem hiding this comment.
cascadeBytes is uint64 but is cast to float64 here. If the proto field CascadeKademliaDbBytes is typed as double, this is correct but worth noting that float64 silently loses precision above 2^53 (~9 PB). For realistic DB sizes this is fine. However, if the chain proto field is actually uint64/int64, this cast would silently truncate large values and the assignment would need to change. Worth verifying against the chain proto definition to be safe, given the plan's R1 risk ("Wrong units -> payout distortion").
Fix it with Roo Code or mention @roomote and request a fix.
Aligns both supernode go.mod and tests/system go.mod with the v1.12.0-rc release tag (lumera commit 7ca770a / Everlight #113). Resolves the install-lumera CI step which requires a real downloadable release asset rather than a pseudo-version.
|
Consolidated into #284, which now targets |
1 participant
This PR adds a detailed implementation plan for supernode-side Everlight compatibility with Lumera PR #113.
Highlights:
disk_usage_percent,cascade_kademlia_db_bytes)Plan doc:
docs/plans/everlight-supernode-compat-implementation-plan.md