feat: Escrow Lifecycle Service Layer#74
Merged
SudiptaPaul-31 merged 1 commit intoLumina-eX:mainfrom Apr 28, 2026
Merged
Conversation
Closes Lumina-eX#51 - lib/escrow/types.ts: shared types, DTOs, IEscrowBlockchainAdapter and IEscrowRepository interfaces - lib/escrow/errors.ts: typed domain errors with HTTP status mapping helper - lib/escrow/blockchain.ts: SorobanEscrowAdapter encapsulating all on-chain calls - lib/escrow/repository.ts: EscrowRepository with all SQL isolated from service logic - lib/escrow/service.ts: EscrowService orchestrating create, fund, release, refund, dispute, resolveDispute - lib/escrow/index.ts: clean public barrel export - app/api/escrow/create/route.ts: POST deploy escrow contract - app/api/escrow/fund/route.ts: POST record on-chain funding - app/api/escrow/release/route.ts: POST release milestone funds to freelancer - app/api/escrow/refund/route.ts: POST refund escrow to client - app/api/escrow/dispute/route.ts: POST raise a dispute - app/api/escrow/dispute/resolve/route.ts: POST admin resolves dispute Blockchain logic fully encapsulated behind IEscrowBlockchainAdapter. Service layer is dependency-injected and testable without DB or Soroban. All state transitions validated before side-effects are triggered. Extensible for DAO voting and advanced dispute handling.
|
@pugsley76 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51
Summary
Implements the escrow lifecycle service layer, abstracting all blockchain
logic away from controllers.
Changes
Service Layer (
lib/escrow/)types.ts— All shared types, DTOs, and interfaces (IEscrowBlockchainAdapter, IEscrowRepository)errors.ts— Typed domain errors with escrowErrorToHttpStatus() helperblockchain.ts— SorobanEscrowAdapter encapsulating every on-chain callrepository.ts— EscrowRepository with all SQL isolated from service logicservice.ts— EscrowService: createEscrow, fundEscrow, releaseFunds, refundEscrow, raiseDispute, resolveDisputeindex.ts— Clean public barrel exportAPI Routes (
app/api/escrow/)Architecture