Skip to content

Some improvements and optimizations #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kasmacioma merged 6 commits into from
Oct 2, 2019
Merged

Some improvements and optimizations #4

kasmacioma merged 6 commits into from
Oct 2, 2019

Conversation

@kasmacioma
Copy link
Collaborator

@kasmacioma kasmacioma commented Oct 1, 2019

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines [hm, guidelines???]
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features) [haha, no]
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • New naming for KeyboardKey and MouseButton members (simpler and more convenient)
  • SymRecorder (records all printables events to string when needed)
  • What is the current behavior? (You can also link to an open issue here)
  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    You'll have to replace old keyboard and mouse button with new one

  • Other information:

Anatoly Pitikin added 6 commits September 25, 2019 23:58
Remove old code
2e23d09
[InputEvents] Use constexpr functions instead of macros
fecf810
Update and simplify keys and buttons naming
7a6e6b1 
Use PascalCase (CamelCase) instead of UpperCase.

For keys naming was used https://docs.rs/sdl2/0.32.2/sdl2/keyboard/enum.Scancode.html
Add KeyboardEvent::getPrintableRef
f1aa668
Small simplifications
3fca255
Implement SymRecorder for KeyboardEvent
09f7bae 
And store only last event char ('\0' if event is not printable)
SymRecorder [disabled by default] records all chars from events on demand (after it was activated) to printable user-friendly (means no more '\b' chars and all 'Enter' will be converted to "\r\n") string. 'Backspace' deletes last char.
@kasmacioma kasmacioma self-assigned this Oct 1, 2019
@kasmacioma kasmacioma requested a review from LumpBloom7 October 1, 2019 19:55
@kasmacioma kasmacioma added the enhancement New feature or request label Oct 1, 2019
@kasmacioma
Copy link
Collaborator Author

kasmacioma commented Oct 1, 2019

Maybe later I'll implement event recorder (it may be useful for key combinations in a game).

@kasmacioma kasmacioma merged commit 66f130d into LumpBloom7:feature/InputManager Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LumpBloom7 LumpBloom7 LumpBloom7 approved these changes

Assignees

@kasmacioma kasmacioma

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kasmacioma @LumpBloom7