Feature/liquidity manager poc by amanzag · Pull Request #210 · Lunar-Rails/40swap

amanzag · 2026-02-05T15:08:53Z

No description provided.

Copilot

Pull request overview

This PR introduces a Lightning Network liquidity manager proof-of-concept with authentication via Keycloak, database persistence, and multiple swap strategies for moving Lightning channel balances to Liquid Bitcoin.

Changes:

Added new liquidity manager backend and frontend applications with full OIDC authentication
Extracted LND service into a shared crypto-clients package for reuse across applications
Integrated Keycloak for authentication with PostgreSQL session storage

Reviewed changes

Copilot reviewed 72 out of 300 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
server-backend/tsconfig.json	Added crypto-clients package path reference
server-backend/src/*	Updated imports to use crypto-clients package for LND service
server-backend/package.json	Added crypto-clients dependency, removed gRPC dependencies
liquidity-manager-frontend/*	New frontend application with SolidJS for managing channel liquidity
liquidity-manager-backend/*	New backend API with swap execution, history tracking, and Keycloak auth
crypto-clients/*	New shared package containing LND service extracted from server-backend
docker/*	Added Keycloak service and PostgreSQL initialization for auth databases
package.json	Added new workspace packages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-05T15:10:06Z

+        if (swap.chain !== cryptoCode || swap.contractAddress == null) {
            return;
        }


The null check for swap.contractAddress was added as a guard, but this change may indicate a logic issue. If contractAddress can be null at this point in the process, the code after line 198 (specifically line 212) will still throw an error when trying to use it. Consider adding an early return with a clear error message if contractAddress is null, rather than allowing execution to continue to line 212 where it will fail.

Suggested change

if (swap.chain !== cryptoCode || swap.contractAddress == null) {

return;

}

if (swap.chain !== cryptoCode) {

// Ignore events for other chains

return;

}

if (swap.contractAddress == null) {

this.logger.error(

`Swap ${swap.id} on chain ${swap.chain} has null contractAddress in processNewTransaction`,

);

return;

}

Copilot · 2026-02-05T15:10:07Z

+    async run(): Promise<void> {
+        const swap = await this.repository.findOneByOrFail({ id: this.id });
+        if (swap.status !== 'CREATED') {
+            this.logger.error(`[swap:${swap.id}] Swap is alreay in progress but is not resumable. Failing...`);


Corrected spelling of 'alreay' to 'already'.

Suggested change

this.logger.error(`[swap:${swap.id}] Swap is alreay in progress but is not resumable. Failing...`);

this.logger.error(`[swap:${swap.id}] Swap is already in progress but is not resumable. Failing...`);

Copilot · 2026-02-05T15:10:07Z

 # opening channels one way
 wait_for_chain_sync


A duplicate call to wait_for_chain_sync was removed on line 47, but this appears to be intentional based on the comment '# opening channels one way' on line 48. The removed call may have been serving a purpose before opening channels. Verify that removing this synchronization check doesn't cause timing issues during channel opening.

Copilot · 2026-02-05T15:10:08Z

+            const userInfo = await this.oidcService.getUserInfo(tokenSet.access_token!);
+


Using the non-null assertion operator (!) on tokenSet.access_token assumes it will always be present. Consider adding explicit validation and error handling if the access_token is missing instead of asserting its presence.

Suggested change

const userInfo = await this.oidcService.getUserInfo(tokenSet.access_token!);

if (!tokenSet.access_token) {

this.logger.error('No access token received from token endpoint');

return res.redirect(this.getBaseUrl() + '?error=no_access_token');

}

const userInfo = await this.oidcService.getUserInfo(tokenSet.access_token);

Copilot · 2026-02-05T15:10:08Z

+
+            const tokenSet = await response.json();
+            this.logger.log('Token exchange successful');
+            return tokenSet as any; // TODO


The as any cast with a TODO comment indicates incomplete type handling. Define a proper interface for the token set response instead of using any, which bypasses type safety.

Copilot · 2026-02-05T15:10:08Z

+        if (!strategy) {
+            throw new BadRequestException(`Unknown strategy: ${strategy}. Available strategies: ${this.getAvailableStrategies().join(', ')}`);
+        }
+


The condition if (!strategy) will never be true because the strategy parameter is validated by Zod in the DTO (line 14 of SwapController.ts checks it's a valid enum value). This check is redundant and the error message on line 51 would never be reached. Consider removing this check or revising the validation logic.

Suggested change

if (!strategy) {

throw new BadRequestException(`Unknown strategy: ${strategy}. Available strategies: ${this.getAvailableStrategies().join(', ')}`);

}

Copilot · 2026-02-05T15:10:08Z

+        this.logger.log(`[swap:${swapId}] Starting background execution`);
+        void runner!.run();


Using the non-null assertion operator (!) on runner and then voiding the promise is risky. The switch statement should guarantee runner is defined through the satisfies never check, but consider either removing the assertion and handling the case explicitly, or adding proper error handling for the voided promise.

Suggested change

this.logger.log(`[swap:${swapId}] Starting background execution`);

void runner!.run();

if (!runner) {

this.logger.error(`[swap:${swapId}] No liquidity swap runner found for strategy "${strategy}"`);

return;

}

this.logger.log(`[swap:${swapId}] Starting background execution`);

void runner.run().catch((error) => {

const message =

error instanceof Error

? `${error.message}`

: String(error);

const stack = error instanceof Error ? error.stack : undefined;

this.logger.error(`[swap:${swapId}] Error during background execution: ${message}`, stack);

});

Copilot · 2026-02-05T15:10:09Z

+
+auth:
+  keycloak:
+    url: http://localhost:7085


The Keycloak URL port 7085 doesn't match the port 8080 mentioned in the AUTHENTICATION.md documentation (line 9 and 16). This inconsistency could cause confusion. Consider documenting that 7085 is the external mapped port while 8080 is the internal container port, or update the documentation to consistently use 7085.

Suggested change

url: http://localhost:7085

url: http://localhost:8080

amanzag added 11 commits February 4, 2026 10:31

feat: basic skeleton of liquidity manager app.

57bbd74

feat: fix bitfinex swap strategy in liquidity manager.

3e04284

feat: add peer alias and id to the liquidity manager views.

fcbde7f

feat: add persistence to liquidity manager.

567667f

feat: dumme swap strategy in liquidity manager.

9852a35

feat: basic keycloack authentication in liquidity manager.

adad76d

fix: move liquidity-manager auth config to config file.

db92490

fix: move liquidity-manager keycloak to port 7085.

710c95a

feat: change style of liquidity manager login screen.

31a0081

refactor: extract LndService into common module.

6602749

refactor: liquidity manager strategies.

9cdc490

amanzag requested a review from Copilot February 5, 2026 15:08

Copilot AI reviewed Feb 5, 2026

View reviewed changes

amanzag added 10 commits February 6, 2026 09:56

fix: formatting.

08866fc

fix: integration tests.

0b00972

refactor: simplify Dockerfile.

8fd49c6

build: liquidity-manager Dockerfiles.

18121d0

fix: docker builds.

c736a15

fix: docker builds.

cde06e3

build: liquidity manager build in CI.

41580d6

build: user larger CI runner.

2857924

build: user larger CI runner.

6fd85d3

feat: add peerswap option to the liquidity manager.

9feeb9f

amanzag force-pushed the feature/liquidity-manager-poc branch from 7c947f6 to 9feeb9f Compare March 26, 2026 14:02

amanzag added 3 commits March 27, 2026 13:12

fi: CI

96b0cd1

fix: initialize keycloak client lazily

24f842e

improve error message on OIDC issues.

ff7c0eb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/liquidity manager poc#210

Feature/liquidity manager poc#210
amanzag wants to merge 24 commits intomasterfrom
feature/liquidity-manager-poc

amanzag commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-        if (swap.chain !== cryptoCode || swap.contractAddress == null) {
-            return;
-        }
+        if (swap.chain !== cryptoCode) {
+            // Ignore events for other chains
+            return;
+        }
+        if (swap.contractAddress == null) {
+            this.logger.error(
+                `Swap ${swap.id} on chain ${swap.chain} has null contractAddress in processNewTransaction`,
+            );
+            return;
+        }

	this.logger.error(`[swap:${swap.id}] Swap is alreay in progress but is not resumable. Failing...`);
	this.logger.error(`[swap:${swap.id}] Swap is already in progress but is not resumable. Failing...`);

		const userInfo = await this.oidcService.getUserInfo(tokenSet.access_token!);

-            const userInfo = await this.oidcService.getUserInfo(tokenSet.access_token!);
+            if (!tokenSet.access_token) {
+                this.logger.error('No access token received from token endpoint');
+                return res.redirect(this.getBaseUrl() + '?error=no_access_token');
+            }
+            const userInfo = await this.oidcService.getUserInfo(tokenSet.access_token);

	if (!strategy) {
	throw new BadRequestException(`Unknown strategy: ${strategy}. Available strategies: ${this.getAvailableStrategies().join(', ')}`);
	}

		this.logger.log(`[swap:${swapId}] Starting background execution`);
		void runner!.run();

-        this.logger.log(`[swap:${swapId}] Starting background execution`);
-        void runner!.run();
+        if (!runner) {
+            this.logger.error(`[swap:${swapId}] No liquidity swap runner found for strategy "${strategy}"`);
+            return;
+        }
+        this.logger.log(`[swap:${swapId}] Starting background execution`);
+        void runner.run().catch((error) => {
+            const message =
+                error instanceof Error
+                    ? `${error.message}`
+                    : String(error);
+            const stack = error instanceof Error ? error.stack : undefined;
+            this.logger.error(`[swap:${swapId}] Error during background execution: ${message}`, stack);
+        });

Conversation

amanzag commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants