Pass ASCII commit message to Cloudflare deploy#66
Merged
Conversation
Cloudflare Pages' deployment API rejected the PR #65 docs deploy with "Invalid commit message, it must be a valid UTF-8 string." The commit message contained section sign and arrow glyphs which the API does not accept despite being valid UTF-8. Pass an explicit ASCII commit message based on the GitHub SHA so the deploy step is no longer coupled to the upstream git commit message's character set.
There was a problem hiding this comment.
Pull request overview
Updates the docs deployment workflow to avoid Cloudflare Pages deployment record failures caused by certain Unicode characters in upstream git commit messages, by explicitly supplying an ASCII-only commit message while still associating the deploy with the exact GitHub SHA.
Changes:
- Passes
--commit-hashand an ASCII-only--commit-messagetowrangler pages deployin the docs workflow. - Adds inline workflow documentation explaining the Cloudflare UTF-8 validation failure mode and why the SHA is sufficient for traceability.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--commit-hashand--commit-messageflags to the wranglerpages deploycommand in.github/workflows/docs.ymlWhy
PR #65's docs deploy failed with
Invalid commit message, it must be a valid UTF-8 string. [code: 8000111]because the commit message contained section-sign and arrow glyphs. Files uploaded successfully; the deployment-record creation failed.Passing an explicit ASCII commit message removes the dependency on the upstream git commit message's character set. The actual commit SHA stays attached via
--commit-hash, so cross-referencing to GitHub still works.Test plan