Fetch submodule tags in release workflow test job#75
Merged
Conversation
actions/checkout's submodule clone is shallow and doesn't carry tags. scripts/build_agents_md.py asserts the spec submodule HEAD is AT a v* tag (used by tests/test_agents_md_drift.py). ci.yml has had this step since PR #72; release.yml was missed, so the v0.9.0-rc1 tag's test job failed on the drift check. Build / publish jobs don't regenerate AGENTS.md (they package the committed file via hatchling), so the fix is only needed in the test job.
There was a problem hiding this comment.
Pull request overview
Updates the release workflow’s test job to fetch tags for the openarmature-spec submodule so the AGENTS.md drift test can correctly verify the submodule HEAD is pinned to a v* tag (matching CI behavior).
Changes:
- Add a “Fetch submodule tags” step to
release.yml’s test job (git -C openarmature-spec fetch --tags). - Document why the step is needed and that it mirrors the existing
ci.ymlbehavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git -C openarmature-spec fetch --tagsstep fromci.ymlintorelease.yml's test job.actions/checkout's submodule clone is shallow and doesn't carry tags; the bundled-AGENTS.md drift test calls intoscripts/build_agents_md.py, which asserts the submodule HEAD is AT av*tag.v0.9.0-rc1tag pushed to test the rc-first flow: the release workflow's test job failed withsubmodule HEAD ... is not at a v* tageven though the submodule was pinned at v0.22.1.Test plan
v0.9.0-rc1tag from main; release workflow's test job runs to completion and dispatches to TestPyPI