Miscellaneous fixes and additions#211
Merged
Merged
Conversation
jtravs
approved these changes
Aug 13, 2021
Contributor
jtravs
left a comment
There was a problem hiding this comment.
Looks good to me. Your ZDW change reminded me of a couple of bugs @balazsplosz found a few months back though. I will try to dig them out/remember them.
Collaborator
Contributor
|
Apologies Chris, for highjacking this PR to discuss this issue. We should have opened a new one. If I remember correctly, the issues were:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

CSplinefor out-of-bounds evaluationFieldsto optimise the CEP for maximum field strengthsave_dict_h5now acceptsNamedTuplesas wellaperture_filterwhich approximately calculates the transmission through an aperture for a given core size and distance from exit facefwhm_t_allmodesstatistic which sums up the field in all modes before taking the FWHMModes.transmissiontoz-integrate the loss rather than assuming it's constant--important for tapers (cc @balazsplosz )All tests pass on my machine except for the ones mentioned in #210