Skip to content

Conversation

@ildyria
Copy link
Member

@ildyria ildyria commented Jan 23, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Improved permission checks to accurately assess file permissions by ignoring the sticky bit.
    • Enhanced database driver detection with clearer, context-aware error messages when no suitable driver is available.
    • Adjusted max execution time warnings to only trigger for the sync queue driver.
    • Made image variant existence checks more specific and reliable by tightening query conditions.

✏️ Tip: You can customize this high-level summary in your review settings.

@ildyria ildyria requested a review from a team as a code owner January 23, 2026 14:07
@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

Updates four diagnostic checks: ignore sticky bit in permission comparisons, make DB driver support configuration-aware with early error for unsupported defaults, limit max_execution_time warnings to sync queue driver, and constrain size-variant queries to image types via a join on photos.

Changes

Cohort / File(s) Summary
Permission check
app/Actions/Diagnostics/Pipes/Checks/BasicPermissionCheck.php
Added public constant WITHOUT_STICKY_BIT (0777). Masking of actual and expected permissions now ignores the sticky bit; inline comment notes sticky bit is ignored.
INI / queue check
app/Actions/Diagnostics/Pipes/Checks/IniSettingsCheck.php
max_execution_time warning now only triggers when configured queue driver is sync (in addition to existing numeric bounds).
Database driver validation
app/Actions/Diagnostics/Pipes/Checks/DBSupportCheck.php
Replaced flat driver list with a config-keyed map (by database.default), added early guard/error if default not supported, and adjusted driver iteration and error messaging to reference the configured default and relevant extensions.
SizeVariant queries
app/Actions/Diagnostics/Pipes/Checks/SmallMediumExistsCheck.php
All SizeVariant subqueries now join photos via size_variants.photo_id, filter by photos.type like image/%, and qualify size_variants.type comparisons to avoid ambiguity.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I nibble bits the sticky kind forgot,
I sniff the DB map to find the lot,
I hop when queues are sync and neat,
I scope image rows with careful feet,
Diagnostics bloom where fixes plot.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (4de8828) to head (a11064d).
⚠️ Report is 1 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria merged commit 566db27 into master Jan 23, 2026
44 checks passed
@ildyria ildyria deleted the hide-time-warning-on-worker-config branch January 23, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants