fix: show Back Home button on tablets and phones#4295
Conversation
Co-authored-by: ildyria <627094+ildyria@users.noreply.github.com>
Agent-Logs-Url: https://github.com/LycheeOrg/Lychee/sessions/66872854-46e3-4b2a-b942-d3cb32e4f592 Co-authored-by: ildyria <627094+ildyria@users.noreply.github.com>
📝 WalkthroughWalkthroughThe changes restructure back link button positioning and visibility across header components. BackLinkButton moves from large-screen-only containers to always-rendered sections in AlbumsHeader and TimelineHeader, responsive breakpoints shift from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
resources/js/components/headers/AlbumsHeader.vue (1)
59-62: Scope the spacer wrapper to the same condition asBackLinkButton.Line 60 always renders
mr-12on mobile even when the user is not a guest. Consider moving the condition to the wrapper so empty spacing is not added unnecessarily.♻️ Proposed refactor
- <div class="mr-12 lg:mr-0"> - <BackLinkButton v-if="userStore.isGuest && albumsStore.rootConfig" :config="albumsStore.rootConfig" /> - </div> + <div v-if="userStore.isGuest && albumsStore.rootConfig" class="mr-12 lg:mr-0"> + <BackLinkButton :config="albumsStore.rootConfig" /> + </div>
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f3689731-9114-475a-bf8f-393a09b0815e
📒 Files selected for processing (3)
resources/js/components/headers/AlbumsHeader.vueresources/js/components/headers/BackLinkButton.vueresources/js/components/headers/TimelineHeader.vue
Fixes #4233
Summary by CodeRabbit