-
Notifications
You must be signed in to change notification settings - Fork 24
version 6.8.0 #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version 6.8.0 #230
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughAdds v6.8.0 release notes (tags moved to a many-to-many tags table with autocomplete and tag management), adds pinned albums and other items; updates announcement banner to v6.8.0; modifies Supporter Edition feature matrix (adds Smart Albums and Watermarking, moves/removes isSoon flags, minor text fixes). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates Lychee to version 6.8.0, which introduces significant new features including tags refactoring, pinned albums, and customizable footer copyright text.
- Updates the in-app announcement to promote the new v6.8.0 release
- Adds comprehensive release notes documenting the major changes and improvements in v6.8.0
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/widgets/Announcement.astro | Updates announcement link and text to point to v6.8.0 release |
| docs/releases.md | Adds detailed v6.8.0 release notes documenting new features and fixes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/components/widgets/Announcement.astro (1)
17-18: Nit: tighten vulnerability range wording in the bannerMinor copy improvement for clarity and style (use an en dash, avoid brackets).
- class="text-slate-200 hover:underline dark:text-slate-200 font-medium"><span class="text-red-500 font-bold">CVSS 7.5 in Lychee [6.6.6 to 6.6.9], update as soon as possible!</span> Lychee v6.8.0 is now available! »</a + class="text-slate-200 hover:underline dark:text-slate-200 font-medium"><span class="text-red-500 font-bold">CVSS 7.5 in Lychee (6.6.6–6.6.9), update as soon as possible!</span> Lychee v6.8.0 is now available! »</a
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
docs/releases.md(1 hunks)src/components/widgets/Announcement.astro(1 hunks)
🔇 Additional comments (1)
src/components/widgets/Announcement.astro (1)
17-18: Version banner updated to 6.8.0 — LGTMCorrect link and copy. No functional or accessibility regressions introduced by this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
src/pages/get-supporter-edition.astro (1)
9-11: Typo in page title: “Lyche SE” → “Lychee SE”This is user-facing and impacts SEO/title. Please fix.
- title: 'Lyche SE - Unlock the full capabilities of Lychee with the Supporter Edition.', + title: 'Lychee SE - Unlock the full capabilities of Lychee with the Supporter Edition.',
🧹 Nitpick comments (3)
src/pages/get-supporter-edition.astro (3)
343-355: Watermarking: “isSoon” header conflicts with SE availability flagsHeader is marked isSoon: true while items show available: [false, true]. This can mislead users (coming soon vs. already available in SE). Please clarify intent and make the table consistent.
- If watermarking is not released yet: mark both features as unavailable for both editions (or keep availability unspecified) until launch.
- If watermarking ships now for SE in 6.8.0: drop the isSoon flag on the header.
Option A (coming soon for both editions) — mark unavailable now:
{ feature: 'Custom image as watermark', - available: [false, true], + available: [false, false], }, { feature: 'Customizable scaling, positioning, and opacity', - available: [false, true], + available: [false, false], },Option B (available now for SE) — remove “isSoon” from header:
{ feature: 'Watermarking', isHeader: true, - isSoon: true, },
211-213: Nit: spacing in “download,share”Add a space after the comma for readability.
- feature: 'Statistics (download,share, etc.)', + feature: 'Statistics (download, share, etc.)',- feature: 'Statistics (download,share, etc.)', + feature: 'Statistics (download, share, etc.)',Also applies to: 256-258
55-56: Nit: grammar — “Unlimited photos upload”Prefer “Unlimited photo uploads” for clarity.
Price card item:
- description: 'Unlimited photos upload.', + description: 'Unlimited photo uploads.',Features matrix:
- feature: 'Unlimited photos upload', + feature: 'Unlimited photo uploads',Also applies to: 149-151
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
docs/releases.md(1 hunks)src/pages/get-supporter-edition.astro(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/releases.md
🔇 Additional comments (1)
src/pages/get-supporter-edition.astro (1)
334-337: Smart Albums by tag selection — LGTMGood addition and consistent with the v6.8.0 tags revamp. Placement under Tagging makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
src/pages/get-supporter-edition.astro (1)
10-11: Fix brand typo in page title metadata“Lyche SE” should be “Lychee SE”.
- title: 'Lyche SE - Unlock the full capabilities of Lychee with the Supporter Edition.', + title: 'Lychee SE - Unlock the full capabilities of Lychee with the Supporter Edition.',
♻️ Duplicate comments (2)
docs/releases.md (2)
37-37: Use a fourth-level heading and singular “Tag” for subheading consistencyOther entries use “#### …” under a version header. Also prefer “Tag refactoring” over “Tags refactoring”.
-### Tags refactoring, pinned albums, and more! +#### Tag refactoring, pinned albums, and more!
39-43: Tighten phrasing: “for your account” reads better than “related to your user”Minor grammar/style improvement in a user-facing doc.
-Tags are now stored in their own table and linked to photos via a many-to-many relationship. This change enables tag autocomplete, -and provides a more efficient way to manage your tags. We also added a page that lists all tags in your instance related to your user. +Tags are now stored in their own table and linked to photos via a many-to-many relationship. This change enables tag autocomplete, +and provides a more efficient way to manage your tags. We also added a page that lists all tags in your instance for your account.
🧹 Nitpick comments (4)
src/pages/get-supporter-edition.astro (4)
202-204: Pluralize items in “Statistics (…)” for grammatical consistencyUse plural nouns for parallelism inside parentheses.
Apply this diff:
- feature: 'Statistics (download, share, etc.)', + feature: 'Statistics (downloads, shares, etc.)',Also applies to: 247-249
325-328: Match capitalization to existing “Smart albums” entriesElsewhere the feature is “Smart albums” (lowercase “a”). Align this new entry to match.
- feature: 'Smart Albums by tag selection', + feature: 'Smart albums by tag selection',
334-346: Double-check “isSoon” semantics vs availability flags“Watermarking” is marked
isSoon: truewhile child features areavailable: [false, true]. If “isSoon” means not yet released, consider deferring the availability flags (or removingisSoon) to avoid mixed messaging in the table rendering.
70-72: Unify period capitalization across plans“Per Month” here vs “per month” in the Free plan (Line 46). Pick one style for consistency; suggested: lowercase.
- period: 'Per Month', + period: 'per month',
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
docs/releases.md(1 hunks)src/pages/get-supporter-edition.astro(5 hunks)
🔇 Additional comments (3)
src/pages/get-supporter-edition.astro (2)
55-56: LGTM: wording fix on Free plan item reads more naturally“Unlimited photo upload.” is clearer than the previous phrasing.
140-142: LGTM: consistency with feature matrixKeeping “Unlimited photo upload” under “Global” aligns with the Free plan card.
docs/releases.md (1)
44-63: Nice improvements and clear changelog for v6.8.0Pinned albums note and ESLint copy read well; the section is cohesive after the tag refactor explanation.
Summary by CodeRabbit