Conversation
An issue was observed where, if the Memes & Nickname Announcements channels were the same, the nickname announcement would consistently trigger a deadlock. The cause of this is not very clear, beyond appearing that the waiting write handle from the memes subsystem's New Message handler prevents additional read handles required by the nickname lottery error handling, thereby preventing execution. This addresses the issue in this case by sharing the existing read handle to ensure that the function can finish (and thereby drop the read handle!).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue was observed where, if the Memes & Nickname Announcements channels were the same, the nickname failure announcement would consistently trigger a deadlock.
The cause of this is not very logical to me, beyond appearing that the waiting write handle from the memes subsystem's New Message handler prevents additional read handles required by the nickname lottery error handling, thereby preventing execution. (Surely the read handles should be allowed to simply execute, not be blocked by the waiting write handle? Is it a queue...? I didn't think it was, but perhaps I'm wrong.)
This addresses the issue in this case by sharing the existing read handle to ensure that the function can finish (and thereby drop the read handle!).