-
Notifications
You must be signed in to change notification settings - Fork 3
Add basic HTMLIframeElement support for DOM creation and recognition #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>
Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>
Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>
yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this lock file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed yarn.lock file as requested. 411ddef
| { | ||
| void HTMLIframeElement::createdCallback(bool from_scripting) | ||
| { | ||
| defaultStyle_.setProperty("display", "inline-block"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iframe's display should be block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed iframe display style from "inline-block" to "block" as requested. 411ddef
fixtures/html/iframe-test.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to test iframe element, please remove this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed fixtures/html/iframe-test.html file as requested. 411ddef
docs/HTMLIframeElement.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed docs/HTMLIframeElement.md file as requested. 411ddef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
yorkie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Please update the docs.
yorkie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Update again
… add browser compat data Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>
This PR implements basic HTMLIframeElement support in JSAR Runtime, enabling developers to create and use
<iframe>elements structurally within JSAR applications without embedded content functionality.What's Implemented
document.createElement('iframe')Usage Examples
Implementation Details
The implementation follows the established pattern used by other HTML elements in JSAR:
HTMLIframeElementinherits fromHTMLElementproviding core functionalityHTMLIFrameElementconstructor to JavaScript environmentTYPED_ELEMENT_MAPfor automatic element factory creationdocs/api/browser-compat-data/html/elements/iframe.jsonIntentional Limitations
As specified in the requirements, this implementation provides structural support only:
Iframe elements are treated as regular DOM elements that can be created, styled, and positioned, but do not load or display any content.
Fixes #157.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.