feat:implement WebGL vertex attribute methods #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@EndlessJour9527 You can run |
EndlessJour9527
force-pushed
the
feat/imp-vertex-attributes
branch
from
acf34c9 to
dec5b43
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements WebGL vertex attribute methods and buffer clearing operations. The implementation adds support for setting generic vertex attributes with float values (vertexAttrib1f/2f/3f/4f) and integer values (vertexAttribI4i/ui/iv/uiv), as well as selective buffer clearing methods (clearBufferfv/iv/uiv/fi) as specified in the WebGL 2.0 specification.
- Adds command buffer support for vertex attribute operations with proper parameter validation and type checking
- Implements selective buffer clearing operations with command buffer serialization
- Provides both WebGLAttribLocation and index-based attribute setting for compatibility
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/render_api_opengles.cpp | Added OpenGL ES command handlers for vertex attribute and buffer clearing operations |
| src/common/command_buffers/shared.hpp | Added command buffer type definitions for new vertex attribute and buffer operations |
| src/common/command_buffers/macros.hpp | Added command buffer macro definitions for new operations |
| src/common/command_buffers/details/vertex_attrib.hpp | Implemented command buffer request classes for vertex attribute operations |
| src/common/command_buffers/details/clear.hpp | Implemented command buffer request classes for buffer clearing operations |
| src/client/graphics/webgl_context.hpp | Added method declarations for vertex attribute and buffer operations |
| src/client/graphics/webgl_context.cpp | Implemented WebGL context methods for vertex attributes and buffer clearing |
| src/bindings/webgl/rendering_context.hpp | Added JavaScript binding declarations for new WebGL methods |
| src/bindings/webgl/rendering_context.cpp | Implemented JavaScript bindings for WebGL2 methods |
| src/bindings/webgl/rendering_context-inl.hpp | Added template implementations for base WebGL vertex attribute methods |
| fixtures/html/clearbufferfv-test.html | Added test HTML file for clearBufferfv functionality |
| docs/manual/references/webgl.md | Updated documentation to remove "not implemented" markers |
yorkie
requested changes
Aug 13, 2025
added 3 commits
August 14, 2025 16:46
…e argument The 4th argument (stride) of vertexAttribIPointer should be validated as a number, not a boolean. This fixes the incorrect type checking that was causing validation errors.
yorkie
requested changes
Aug 18, 2025
yorkie
requested changes
Aug 19, 2025
yorkie
requested changes
Aug 19, 2025
added 2 commits
August 20, 2025 11:03
yorkie
requested changes
Aug 20, 2025
src/renderer/render_api_opengles.cpp
Outdated
| GLint drawbuffer = req->drawbuffer; | ||
| const GLfloat *value = req->values.data(); | ||
| glClearBufferfv(buffer, drawbuffer, value); | ||
| GLenum error = glGetError(); |
yorkie
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement WebGL vertex attribute methods
Add vertexAttrib1f/2f/3f/4f methods for setting vertex attributes
Add vertexAttribI4i/4ui/4iv/4uiv methods for integer vertex attributes
Implement command buffer support for vertex attribute operations
Add proper parameter validation and type checking
Support both WebGLAttribLocation and index-based attribute setting"
implement WebGL buffer operations
Add clearBufferfv/iv/uiv/fi methods for selective buffer clearing
Add command buffer support for buffer operations
Improve command buffer response handling with timeout detection
Add proper serialization for pixel data transfer"
test case
gl-bindAttribLocation-aliasing-inactive
clearbufferfv-with-alpha-false