-
Notifications
You must be signed in to change notification settings - Fork 3
Implement blocking script execution order for HTMLScriptElement #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>
…tation Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Support blocking execution order for HTMLScriptElement (document-order script execution)
Implement blocking script execution order for HTMLScriptElement
Aug 27, 2025
yorkie
requested changes
Aug 27, 2025
- Use ScriptExecutionHandle with IDs and weak pointers instead of direct HTMLScriptElement references - Remove test file and documentation as requested - Maintain same functionality with better decoupling Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
EndlessJour9527
approved these changes
Aug 28, 2025
yorkie
approved these changes
Aug 28, 2025
yorkie
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements document-order script execution for
HTMLScriptElementto match classic browser behavior, where scripts execute in the order they appear in the DOM regardless of download completion order.Problem
Previously, JSAR executed scripts immediately upon compilation completion, which could result in out-of-order execution if later scripts downloaded faster than earlier ones. This behavior differs from standard browser implementations and can break web content that relies on strict script execution order.
Solution
Introduced a script execution queue in
BrowsingContextthat ensures classic scripts (those withoutasync,defer, ortype="module") execute in document order:Implementation Details
ScriptExecutionHandlewith script IDs and weak pointers to avoid circular dependencies betweenBrowsingContextandHTMLScriptElementstd::deque<ScriptExecutionHandle>to track scripts in document orderconnectedCallback()Key Features
Files Changed
src/client/dom/browsing_context.hpp- Added execution queue interface with decoupled designsrc/client/dom/browsing_context.cpp- Implemented queue management logic using script handlessrc/client/html/html_script_element.hpp- Added queue integration methodssrc/client/html/html_script_element.cpp- Modified execution flow to use queueThis change improves web compatibility by ensuring JSAR's script execution behavior aligns with browser standards while maintaining a clean, decoupled architecture.
Fixes #250.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.