Refining use of tristate checkboxes

[cobaltdr]

I love the new tristate checkboxes.

However, a few points to note:

1. Usage has not yet been implemented into the application view. Now that we do have the checkboxes, can we move to a normal behaviour for such checkboxes, ie, choosing one child greys the parent, choosing all children checks the parent. Checking and in checking the parent checks and unchecks the children? At the moment, to set the children, you have to 'enable' the parent checkbox, and then uncheck the children. Current behaviour in Xpriivacy of app setting bistate checkboxes can now be made more intuitive.
2. Whilst not necessarily a bug, people need to realise that checking/unchecking a whole app will obviously not set or unset the 'red' categories. The tristate checkbox is not shaded to reflect this. So it is possible to be in the main view with apps showing as completely checked, whilst having for example Internet unchecked. The opposite is also true. You can have Internet checked but the app's tristate checkbox will remain unchecked. As expected, it only reflects non-red settings. Point Feature request: modifier for granularity of settings.  #25 in the FAQ needs a slight update.
3. The new checkboxes are beautiful.

[tonymanou]

1. Yes I planned to add the tristates checkboxes in the app details activity. But as I and M66B said on XDA and in another issue on github ([enhancement] Mark categories containing a mixture of checked and unchecked functions #562 (comment)), it's difficult and require some work because the lists in the app details activity are handled differently than the ones in the main activity.
2. It is (almost) solved with Fix for 'applications with only dangerous restricted are not half-ticked' #593 (will be part of next release). Edit: One little bug remains : when you tick an app, the checkbox goes to the full-tick whereas the dangerous restrictions are not set (it goes back to a half-tick when you refresh the view). I will fix it in next pull request tomorrow. Edit 2: Fixed with Fixed "full-tick diplayed when checking an app in main activity but dang... #598
3. Thanks :)

[M66B]

"At the moment, to set the children, you have to 'enable' the parent checkbox, and then uncheck the children"

This is by design, since the child check boxes are exceptions to the parent check box.

Before changing anything here, we have to think this carefully through, since this is how the XPrivacy core works. The reason for this behavior is performance. If the category is not restricted (the main check box is not checked), then the function restrictions are not evaluated (child check boxes). This is also the reason the child check boxes get grayed if you disable the main check box. So, the main check box actually determines if the child check boxes have a meaning or not, not the other way around. You cannot simply say that if all child check boxes are enabled or disabled, the parent check box should be enabled or disabled (although disabling all child check boxes could disabled the parent check box and even that can lead to problems, when a method restriction is added in a later version).

"The tristate checkbox is not shaded to reflect this"

This is also for design. The reddish restrictions are for expert users only.

[cobaltdr]

It's all good as long as this is all consistent. I'll go with performance anytime.