feat: expect SNS topics to be provided instead of created here#94
Merged
feat: expect SNS topics to be provided instead of created here#94
Conversation
Collaborator
Author
|
I deployed this branch to the test deployment with the new SNS topic configured and tested a catalog.json upload - the ingestion worked! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make it easier to allow multiple SQS queues from other accounts subscribe to catalog.json upload events we are moving the SNS topic out of the maap-eoapi stack and configuring it in the same accounts as the buckets.
This PR factors the SNS topic creation out of the userSTAC stack and instead relies on an optional array of SNS topic arns that the DpsStacItemGenerator SQS queue will subscribe to.
Resolves https://github.com/NASA-IMPACT/active-maap-sprint/issues/1389