Conversation
…ncl. basic unit tests to verify execution. Also verified that docfx can generate the HTML
…mmands for UI elements such as click events, incl. unit tests to verify execution.
… based navigation for Windows, Android and iOS
…gments. Built in a similar way to the Windows Frame component. Tested the execution using the sample application to verify that the structure could potentially work.
Also updated all XML docs.
tom-made
requested changes
May 21, 2018
Contributor
tom-made
left a comment
tom-made
left a comment
There was a problem hiding this comment.
Just a few minor changes required.
| @@ -0,0 +1,37 @@ | |||
| #if WINDOWS_UWP | |||
| @@ -1,46 +0,0 @@ | |||
| # Contributor Covenant Code of Conduct | |||
Contributor
There was a problem hiding this comment.
We probably still need this file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Title
Added common logic for application pages across Windows and Android.
Changes include a base page class for Windows Page and Android Support Fragment, a base navigation frame for Windows Frame and Android Activity, and a common navigation service to handle the navigation across both platforms.
Associated Issues
#29 - [Feature] Implement common page/navigation model