Conversation
Member
Author
|
@tom-made apologies for the first part merge. I hadn't synced before branching. |
tom-made
approved these changes
Jun 24, 2018
Contributor
tom-made
left a comment
tom-made
left a comment
There was a problem hiding this comment.
Happy with these changes. Thanks for making the GET Stream and PATCH JSON network processes common!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Title
Removed the UWP specific logic from the networking components that was causing an issue with constructing from a .NET Standard library within a UWP application.
Also updated the UWP only network request classes to be common across all platforms.
Associated Issues
#40 - [Bug] JSON network requests cannot be created in common layer running on UWP due to namespace difference