Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds FBX-only tracking and refactors crawling/notification flows, extending database schema, versioning structure, and changelog generation to support selective FBX diffing.
- Add fbx_only flag across DB schema, Discord command, and processing flow
- Extend version files with fbx-files and implement FBX-only changelog/summary path
- Improve error messages and internal logging
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| booth_discord/booth_sqlite.py | Adds fbx_only column and updates item insertion to store it |
| booth_discord/booth_discord.py | Adds fbx_only parameter to the Discord command and passes it to DB insertion |
| booth_discord/booth.py | Clarifies not found/not purchased exception message |
| booth_checker/shared.py | Initializes version files with fbx-files field |
| booth_checker/booth_sqlite.py | Updates SELECT to include fbx_only for checker consumption |
| booth_checker/main.py | Wires FBX-only processing, version-file handling, and changelog generation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings across the codebase, focusing on modularizing the BOOTH crawling logic, enhancing error handling and user notifications, and improving database and configuration management. The most significant changes are the refactoring of the crawling logic for maintainability, the addition of new features such as the "FBX only" flag, and improvements to error messaging and notification behavior.
Refactoring and Modularization:
booth_checker/booth.pyto use modular helper functions (_crawling_base,_extract_download_info) and selector dictionaries, improving code readability and maintainability. The crawling functions now support more flexible and reusable extraction logic.Feature Additions and Enhancements:
fbx_onlyflag to both the database schema (booth_itemstable) and the Discord command interface, enabling users to specify if only FBX file changes should be tracked. This includes updates to the database methods, Discord command definitions, and related data handling. [1] [2] [3] [4] [5] [6]shared.pyto include a newfbx-filesfield, preparing for future support of FBX-specific tracking.Error Handling and User Notifications:
booth_discord/booth_discord.py: error messages now more clearly explain the likely cause (such as session cookie expiration), and users are notified only after persistent errors, reducing unnecessary alerts. Logging has been enhanced for better traceability.booth_discord/booth.pywhen a product is not found or not purchased.Database and Code Quality Improvements:
booth_discord/booth_sqlite.pyby simplifying duplicate checks and result handling, and moving imports to avoid circular dependencies. [1] [2] [3]Configuration and Utility Updates:
dry_runflag to the sample configuration file for easier testing and deployment.S3Uploader) incloudflare.pyfor better encapsulation and usability.These changes collectively enhance the maintainability, usability, and reliability of the BOOTH checker and Discord bot system.