feat: 401,404,500 엣지케이스 Error 컴포넌트로 통일 #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

junjeeong merged 3 commits into dev from feature/404-페이지

Apr 21, 2025

Collaborator

junjeeong commented Apr 17, 2025 •

edited

Loading

Pull requests

✅ 작업한 내용

401, 404, 500 erorr가 날 때 보여줄 엣지 케이스 컴포넌트를 Error 컴포넌트 하나로 만들었습니다.

🔢 #201

❗️PR Point

401,404,500 상태 코드를(string) prop으로 전달해주면 상응하는 에러 페이지가 렌더링 됩니다.

📸 스크린샷

404.mov


          feat: 404.tsx 개발

97474e3

junjeeong added the 👩‍💻 Feat label

junjeeong self-assigned this

junjeeong linked an issue

that may be closed by this pull request

Feat: 엣지 케이스 페이지 개발 #201

Closed


          ref: 401,404,500 하나의 컴포넌트로 공통화

936ebe5

junjeeong changed the title ~~feat: 404.tsx 개발~~ feat: 401,404,500 엣지케이스 Error 컴포넌트로 통일

junjeeong requested a review from Soohyuniii

April 17, 2025 13:06

Soohyuniii reviewed

View reviewed changes

src/pages/Error.tsx Outdated

+              import PrimaryButton from "@/components/button/PrimaryButton";
+              import { useNavigate } from "react-router-dom";
+              const Error = ({ mode }: { mode: "401" | "404" | "500" }) => {

Collaborator

Soohyuniii Apr 17, 2025

mode가 상태 코드이므로 statusCode나 code등의 이름을 사용하면 좋을 것 같습니다!

Collaborator Author

junjeeong Apr 21, 2025 •

edited

Loading

6801a89 반영했습니다!


          chore: mode -> statuscode 정정

6801a89

Soohyuniii approved these changes

View reviewed changes

junjeeong merged commit 15b0b8d into dev

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👩‍💻 Feat