Skip to content

fix: Mbti test result 페이지에서 공유하기했을 때 url에 mbti가 들어갈 수 있도록 변경 #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
junjeeong merged 2 commits into from
May 10, 2025
Merged

fix: Mbti test result 페이지에서 공유하기했을 때 url에 mbti가 들어갈 수 있도록 변경 #263

junjeeong merged 2 commits into from
May 10, 2025

Conversation

@junjeeong
Copy link
Collaborator

@junjeeong junjeeong commented May 10, 2025 •
edited
Loading

Pull requests

✅ 작업한 내용

  • Mbti test result 페이지에서 mbti를 불러올 때 동적 파라미터에서 가져오도록 수정했습니다.
  • mbtiTestPageState에서 발생하는 typeError를 수정했습니다.

🔢 #260

❗️PR Point

  • 기존에 Mbtit-test-result 페이지에서 mbti를 가져올 때 전역 상태값으로 가져왔는데 페이지 공유를 하면 상태값은 공유되지 않으니 null이 되는 문제가 발생했습니다. 이를 동적 파라미터로 가져오게끔 수정해 개선했습니다.

📸 스크린샷

스크린샷 2025-05-10 오전 9 39 19

@junjeeong junjeeong requested a review from Soohyuniii May 10, 2025 00:46
@junjeeong junjeeong self-assigned this May 10, 2025
@junjeeong junjeeong added the 🐞 Bug 버그 label May 10, 2025
@junjeeong junjeeong linked an issue May 10, 2025 that may be closed by this pull request
Bug: Mbti-test-result 페이지 공유 안되는 문제 해결 건 #260
Closed
@junjeeong junjeeong added the 🛠️ Fix 수정 label May 10, 2025
@junjeeong junjeeong merged commit a51ffbb into dev May 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Soohyuniii Soohyuniii Soohyuniii approved these changes

Assignees

@junjeeong junjeeong

Labels

🐞 Bug 버그 🛠️ Fix 수정

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Mbti-test-result 페이지 공유 안되는 문제 해결 건

3 participants

@junjeeong @Soohyuniii