Spectator-Teleport Implementation #1825
Conversation
ReinforceZwei
left a comment
ReinforceZwei
left a comment
There was a problem hiding this comment.
Thank you for your contribution! The work is perfect for a first time contribution. Just remove the extra spaces and you are good to go.
|
Short question about making pull request cleaner: can I delete commits of an pr to undo their changes and not having to do another commit to undo? Also thanks for reacting so quick! |
xXjojaXx
changed the title
|
You may reset work directory or rebase branch and push again. But deleting commit is like rewriting the history. It is not recommended when you are working on the same branch with others. It's okay to leave the commits here as is. Github can combine multiple commits into single commit before merging into master branch. |
|
Good job! Nice contribution 👍 Just in case, for the sake of compatibility between Minecraft versions did you check on wiki.vg what is the minimum version supporting the Spectator teleport and made sure the packet has not changed between version? |
|
The packet was introduced in 1.8 and has remained unchanged since then. |
Feature not supported by Minecraft 1.7, only 1.8+
|
OK, added a version check 😉 |
3 participants
I just implemented what I requested in an Issue. Hope I did it right, because this is my first pull request. Feel free to change anything or tell me what should be different, if there is any kind of Enhancement or Problem to take care of. Basically this change allows MCC-Users to use
SpectatorTeleport(Player from GetEntities())andSpectatorTeleport(new Guid(String of Player or Entity-UUID))int their Chatbots.