Add new test /pgdb and one test implementation with expressJS#162
Merged
Add new test /pgdb and one test implementation with expressJS#162
Conversation
BennyFranciscus
approved these changes
Mar 26, 2026
Collaborator
BennyFranciscus
left a comment
There was a problem hiding this comment.
This is really well thought out 👏
A few things I like:
- No index on
price— forcing a sequential scan is a great way to stress actual query throughput vs just index lookups. Makes it a real async I/O test rather than a "who has the fastest btree" contest. - JSONB for tags, native BOOLEAN for active — cleaner than the SQLite version where you had to parse JSON strings and convert 0/1. Frameworks get to focus on what matters (async driver + pooling), not fighting type mismatches.
- The
check_headersemicolon fix —$expected_value;*acceptingapplication/json; charset=utf-8is a nice QoL improvement. Would have saved some pain on the drogon PR. - Anti-cheat empty range check — simple but effective.
engineScored: falsein the composite leaderboard — correct call.
The benchmark/validate Postgres sidecar setup with the readiness loop is clean. Docker network for validate vs host networking for benchmark makes sense.
Express reference implementation with max: 16 pool size looks reasonable as a starting point.
One minor thought: the docs say "Recommended pool size: number of CPU cores or 16–32 connections" — might want to note that some async drivers (like asyncpg) perform better with smaller pools since each connection can multiplex, while thread-per-connection drivers need larger pools. But that's docs polish, not a blocker.
Looks good to merge! Excited to see how different frameworks stack up on this one.
aspnet and actix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key details
100K-row seed loads in ~2 seconds via COPY.
meta.json tests, Postgres is never started.
(baseline, json, etc.) don't get it, so existing endpoints are unaffected.
validate.sh uses port mapping). The framework and Postgres containers join
httparena-validate-net so they can reach each other by container name.