fix(fiber): use built-in compression middleware instead of manual gzip/deflate#222
Merged
fix(fiber): use built-in compression middleware instead of manual gzip/deflate#222
Conversation
…p/deflate Replace hand-rolled compress/flate and compress/gzip writers with Fiber's built-in compress middleware (github.com/gofiber/fiber/v2/middleware/compress). The middleware is applied globally with LevelBestSpeed. It handles Accept-Encoding negotiation, Content-Encoding headers, and compression automatically — the /compression handler just sends the raw payload and lets the framework decide whether to compress based on client headers. Other endpoints (baseline, json, etc.) won't be affected since wrk doesn't send Accept-Encoding by default. Fixes #221
Owner
|
@BennyFranciscus we dont use wrk, it's gcannon btw |
Collaborator
Author
|
Oh right, my bad — gcannon, not wrk. Brain was on autopilot there 😅 I'll fix the PR description. Point still stands though — gcannon doesn't send |
Kaliumhexacyanoferrat
approved these changes
Mar 28, 2026
Owner
|
The intended way by the framework, if it supports middleware for it, use it, if not then use the other approach |
Collaborator
Author
|
Yeah exactly, that's what this PR does — Fiber has Anything else you want changed or is this good to go? |
Owner
|
/benchmark compression |
Contributor
|
🚀 Benchmark run triggered for |
Contributor
Benchmark ResultsFramework: Full log |
Collaborator
Author
|
Nice — 13.6K req/s at 4096c, holds up well at 16384c too (11.6K). The middleware approach is performing solidly. Memory does climb a bit at high concurrency (10.6GiB at 16K connections) but that's expected with that many goroutines managing compressed buffers. Looks good to me. Happy with how this landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the hand-rolled
compress/flateandcompress/gzipwriters in the/compressionhandler with Fiber's built-incompressmiddleware.What changed
Accept-Encodingparsing, manualContent-Encodingheader setting, directflate.NewWriter/gzip.NewWriterLevelcallscompress.New(compress.Config{Level: compress.LevelBestSpeed})applied globally viaapp.Use()/compressionhandler just sends the raw JSON payload. Fiber's middleware handles Accept-Encoding negotiation and compression transparently.Why
As flagged in #221, the previous implementation bypassed Fiber's documented compression API. The benchmark should measure how Fiber handles compression, not how Go's stdlib compressors perform behind Fiber's router.
Impact on other endpoints
None — gcannon doesn't send
Accept-Encodingheaders by default, so baseline, json, upload, db, etc. won't be compressed. Only the compression test (which explicitly sendsAccept-Encoding: gzip) will trigger compression.Fixes #221