refactor: improve local development resilience and add SKIP_TUNE#641
Merged
MDA2AV merged 1 commit intoMDA2AV:mainfrom Apr 26, 2026
Merged
refactor: improve local development resilience and add SKIP_TUNE#641MDA2AV merged 1 commit intoMDA2AV:mainfrom
MDA2AV merged 1 commit intoMDA2AV:mainfrom
Conversation
- Make CPU pinning (cpuset-cpus) dynamic based on host core count - Add SKIP_TUNE environment variable to bypass sudo-required system tuning - Update documentation to reflect new dynamic defaults and configuration options
Owner
|
Typically for local development you'd want to use the lite script version benchmark-lite.sh, it doesn't pin to specific cores and uses a much lower connection count. The system_tune is still called though, that can be adjusted. Wouldn't it be better to extend the lite version or do you see a need to be able to run the original benchmark script locally too? |
Contributor
Author
|
It's nice to be able to debug high connection counts (like for race conditions) without crashing on a 16-core laptop. The main entry point should "just work" for everyone, I think! |
MDA2AV
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.