-
Notifications
You must be signed in to change notification settings - Fork 47
Sdg23 add events page #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sdg23 add events page #450
Conversation
micaela-matta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good:)
|
Thanks @micaela-matta for your comments. I have incorporated them. |
jennaswa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for putting this together, @namiroues! As we discussed today, I think it would be good to make as much information as possible about our events that is publicly available accessible from this page. I have added a number of suggestions for consideration to help achieve this.
In addition, I added email links to the UGM and workshop organizing committees to create a communication channel for people who might want to get involved. I'd appreciate thoughts from others on this.
|
I also haven't added it myself, because I'm not sure how detailed we should go, but it'd also be great to highlight hackathons here. Maybe just a general blip in the intro paragraphs is enough, as the UGM/workshop materials should link to hackathon materials in most cases. Per conversation in #444, it might make sense to link directly to the past workshop information here. |
|
Thanks @jennaswa for your comments. I've addressed them. Regarding this comment, I will add this to the TODO list for final refinement. |
Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com>
7bad868 to
72f0220
Compare
micaela-matta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jennaswa why do we need to link to past workshop announcements?
orbeckst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@namiroues can you please replace explicit URLs to internal posts with {% post_url ... %}? Otherwise looks very good.
(Sorry I hadn't reviewed before, I was happy to have @micaela-matta and @jennaswa look over events but as I was asked to comment, here is my review.)
|
|
||
| ## Upcoming Events | ||
|
|
||
| - [Upcoming Event Name](#) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be an automated piece of code, based on tags. (Future work.)
|
Thanks @orbeckst! Done! |
|
@jennaswa I'm going to go ahead and merge for now, but @namiroues compiled a todo list we can use for future changes. let's have another look once all the pages are updated |
This PR addresses #441.