Skip to content

Conversation

@namiroues
Copy link
Contributor

@namiroues namiroues commented Mar 13, 2025

This PR addresses #441.

@namiroues namiroues added the SDG23 work on Small Development Grant 2023 label Mar 13, 2025
@namiroues namiroues changed the title add events page Sdg23 add events page Mar 13, 2025
Copy link
Contributor

@micaela-matta micaela-matta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good:)

@namiroues
Copy link
Contributor Author

Thanks @micaela-matta for your comments. I have incorporated them.

Copy link
Contributor

@jennaswa jennaswa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for putting this together, @namiroues! As we discussed today, I think it would be good to make as much information as possible about our events that is publicly available accessible from this page. I have added a number of suggestions for consideration to help achieve this.

In addition, I added email links to the UGM and workshop organizing committees to create a communication channel for people who might want to get involved. I'd appreciate thoughts from others on this.

@jennaswa
Copy link
Contributor

jennaswa commented Mar 14, 2025

I also haven't added it myself, because I'm not sure how detailed we should go, but it'd also be great to highlight hackathons here. Maybe just a general blip in the intro paragraphs is enough, as the UGM/workshop materials should link to hackathon materials in most cases.

Per conversation in #444, it might make sense to link directly to the past workshop information here.

@namiroues
Copy link
Contributor Author

Thanks @jennaswa for your comments. I've addressed them. Regarding this comment, I will add this to the TODO list for final refinement.

namiroues and others added 4 commits March 17, 2025 21:27
Co-authored-by: Jenna M Swarthout Goddard <38287809+jennaswa@users.noreply.github.com>
@namiroues namiroues force-pushed the sdg23-add-events-page branch from 7bad868 to 72f0220 Compare March 17, 2025 21:29
Copy link
Contributor

@micaela-matta micaela-matta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennaswa why do we need to link to past workshop announcements?

@micaela-matta micaela-matta self-assigned this Mar 18, 2025
@micaela-matta
Copy link
Contributor

@orbeckst @jennaswa can you please check it's all good? if I don't hear from you in the next couple of days, I'll merge

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@namiroues can you please replace explicit URLs to internal posts with {% post_url ... %}? Otherwise looks very good.

(Sorry I hadn't reviewed before, I was happy to have @micaela-matta and @jennaswa look over events but as I was asked to comment, here is my review.)


## Upcoming Events

- [Upcoming Event Name](#)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be an automated piece of code, based on tags. (Future work.)

@namiroues
Copy link
Contributor Author

Thanks @orbeckst! Done!

@micaela-matta
Copy link
Contributor

@jennaswa I'm going to go ahead and merge for now, but @namiroues compiled a todo list we can use for future changes. let's have another look once all the pages are updated

@micaela-matta micaela-matta merged commit dbd5f0e into MDAnalysis:master Mar 27, 2025
1 check passed
@namiroues namiroues deleted the sdg23-add-events-page branch April 2, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SDG23 work on Small Development Grant 2023

Development

Successfully merging this pull request may close these issues.

4 participants