Skip to content

Rename run_analsis to run_analysis and move -nt to base args#108

Merged
PicoCentauri merged 7 commits intoMDAnalysis:mainfrom
hejamu:fix-num_threads
Feb 21, 2023
Merged

Rename run_analsis to run_analysis and move -nt to base args#108
PicoCentauri merged 7 commits intoMDAnalysis:mainfrom
hejamu:fix-num_threads

Conversation

@hejamu
Copy link
Collaborator

@hejamu hejamu commented Feb 20, 2023

Fixes #109, #110

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (72d3aea) to head (4160d68).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   83.06%   85.22%   +2.16%     
==========================================
  Files           8        8              
  Lines         555      555              
  Branches      116      116              
==========================================
+ Hits          461      473      +12     
+ Misses         77       67      -10     
+ Partials       17       15       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaomcteixeira
Copy link
Member

Many thanks @hejamu !!
@PicoCentauri , I suggest we wait for #106 to be merged so that all new tests also run here before merging this one.
Cheers,

@joaomcteixeira joaomcteixeira added bug Something isn't working enhancement New feature or request labels Feb 21, 2023
@PicoCentauri
Copy link
Collaborator

Yes I am finishing this now.

Copy link
Collaborator

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @hejamu

@PicoCentauri PicoCentauri merged commit 2dd8720 into MDAnalysis:main Feb 21, 2023
@PicoCentauri PicoCentauri mentioned this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mdacli broken since 0.1.20

3 participants