changed comparisons of scalars to use pytest.approx function

[yickysan]

…arison of arrays to use numpy.testing.assert_allclose function

Fixes #

Changes made in this Pull Request:

PR Checklist

• Tests?
• Docs?
• CHANGELOG updated?
• Issue raised/referenced?

---

📚 Documentation preview 📚: https://readthedocs-preview--4090.org.readthedocs.build/en/4090/

[github-actions]

Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on the developer mailing list so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (09b8b16) 93.56% compared to head (4086def) 93.56%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4090   +/-   ##
========================================
  Coverage    93.56%   93.56%           
========================================
  Files          191      191           
  Lines        25083    25083           
  Branches      4050     4050           
========================================
  Hits         23470    23470           
  Misses        1093     1093           
  Partials       520      520           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[RMeli]

Hi @yickysan, thanks for your work. Unfortunately there is already an open PR under review related to this issue: #4064 Unfortunately it was not properly linked to the issue and therefore it was not easy to spot, sorry.

PR #4064 will take precedence (since it's older), but you can leave this one open. If things don't work out in #4064, we will consider your PR instead. In the meantime you can work on something else if you want.

Regarding your question about the darker_lint (#3743 (comment)), it appears to be related to #4067. You can ignore it for the time being.

[yickysan]

Hi @yickysan, thanks for your work. Unfortunately there is already an open PR under review related to this issue: #4064 Unfortunately it was not properly linked to the issue and therefore it was not easy to spot, sorry.

PR #4064 will take precedence (since it's older), but you can leave this one open. If things don't work out in #4064, we will consider your PR instead. In the meantime you can work on something else if you want.

Regarding your question about the darker_lint (#3743 (comment)), it appears to be related to #4067. You can ignore it for the time being.

Thank you very much. I'll find another project to work on.

[RMeli]

I'll find another project to work on.

@yickysan just to clarify, what I meant by "something else" is other open issues (that have no open PRs against them). You can have a look at the "good first issue" (https://github.com/MDAnalysis/mdanalysis/issues?q=is%3Aopen+is%3Aissue+label%3Agood-first-issue) and the "difficulty easy" (https://github.com/MDAnalysis/mdanalysis/issues?q=is%3Aopen+is%3Aissue+label%3ADifficulty-easy) ones as a starting point.