Skip to content

Add pytest-timeout to CI#4215

Merged
IAlibay merged 7 commits intodevelopfrom
pytest-timeout
Jul 31, 2023
Merged

Add pytest-timeout to CI#4215
IAlibay merged 7 commits intodevelopfrom
pytest-timeout

Conversation

@IAlibay
Copy link
Copy Markdown
Member

@IAlibay IAlibay commented Jul 30, 2023 •
edited by github-actions Bot
Loading

Temporary patch for #4209

Changes made in this Pull Request:

  • Add pytest-timeout to gh actions, azure and Cirrus

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

📚 Documentation preview 📚: https://mdanalysis--4215.org.readthedocs.build/en/4215/

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 30, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (ac30c88) 93.62% compared to head (9d24830) 93.62%.
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #4215   +/-   ##
========================================
  Coverage    93.62%   93.62%           
========================================
  Files          193      193           
  Lines        25294    25295    +1     
  Branches      4063     4063           
========================================
+ Hits         23682    23683    +1     
  Misses        1096     1096           
  Partials       516      516

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 30, 2023 •
edited
Loading

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

tylerjereddy
tylerjereddy approved these changes Jul 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and FWIW SciPy also has pytest-timeout in some of our CI runs and pyproject.toml optional deps. Looks like threshold is 60 s over there.

We should probably check this more closely as noted in the matching issue, but core devs seem in favor of this temporary solution over there in any case.

test_streamplot_2D mentioned over there is probably for me to investigate, I wrote that with Matthieu.

The only failures I saw in this PR when CI last flushed were timeouts at > 100 s, which is actually pretty wild for a single test!

@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Jul 30, 2023

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 30, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Jul 31, 2023

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Jul 31, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@IAlibay IAlibay merged commit 66a2b21 into develop Jul 31, 2023
@IAlibay IAlibay deleted the pytest-timeout branch July 31, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylerjereddy tylerjereddy tylerjereddy approved these changes

Assignees

No one assigned

Labels

Continuous Integration maintainability

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IAlibay @tylerjereddy