Skip to content

LGPL switch#4794

Merged
orbeckst merged 13 commits intodevelopfrom
lgplv2.1
Nov 22, 2024
Merged

LGPL switch#4794
orbeckst merged 13 commits intodevelopfrom
lgplv2.1

Conversation

@IAlibay
Copy link
Copy Markdown
Member

@IAlibay IAlibay commented Nov 20, 2024

As per https://www.mdanalysis.org/2023/09/22/licensing-update/#detailing-our-proposed-relicensing-process

We are now at step 3, where we package under LGPLv3+ until we remove our apache dependencies.

Changes made in this Pull Request:

  • Update LICENSE files (LGPLv3+)
  • Update all code references of GPLv2+ to LGPLv2.1+

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4794.org.readthedocs.build/en/4794/

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.64%. Comparing base (b254921) to head (ffe8371).
Report is 52 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4794      +/-   ##
===========================================
- Coverage    93.66%   93.64%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21742    22808    +1066     
  Branches      3055     3055              
===========================================
+ Hits         20365    21358     +993     
- Misses         930     1003      +73     
  Partials       447      447              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay changed the title [WIP - HOLD] LGPL switch. [HOLD] LGPL switch. Nov 20, 2024
Copy link
Copy Markdown
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • source code: LGPLv2.1+
  • overall package: LGPLv3+ (for now)

Main question: Do we need to include the text of GPLv3 because LGPLv3 incorporates it?

Comment thread LICENSE
Comment thread LICENSE Outdated
Comment thread testsuite/LICENSE Outdated
Comment thread testsuite/LICENSE
Comment thread LICENSE
@IAlibay
Copy link
Copy Markdown
Member Author

IAlibay commented Nov 20, 2024

Thanks @orbeckst I just added the text because "why not" and centered the LGPLv3 header.

@IAlibay IAlibay requested a review from orbeckst November 20, 2024 21:02
Copy link
Copy Markdown
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing, otherwise LGTM. Thanks for the massive effort!

Comment thread package/MDAnalysis/analysis/bat.py Outdated
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
@orbeckst orbeckst changed the title [HOLD] LGPL switch. LGPL switch Nov 22, 2024
@orbeckst
Copy link
Copy Markdown
Member

@MDAnalysis/coredevs the license change has been approved by final vote and we will merge this PR in order to switch the license of MDAnalysis to LGPL (as detailed above).

Thank you everyone for their support in this 3-year long process.

@orbeckst orbeckst self-assigned this Nov 22, 2024
@orbeckst orbeckst merged commit 0a91d2c into develop Nov 22, 2024
@orbeckst orbeckst deleted the lgplv2.1 branch November 22, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants