Fix: String class breaks when using numpy >=2 with npbytes.#2808
Closed
santorofer wants to merge 2 commits intoMDSplus:alphafrom
Closed
Fix: String class breaks when using numpy >=2 with npbytes.#2808santorofer wants to merge 2 commits intoMDSplus:alphafrom
santorofer wants to merge 2 commits intoMDSplus:alphafrom
Conversation
In the String class, check for Python version when using npbytes and npunicode Fixes MDSplus#2807
Contributor
Author
|
The added logic works well with: Python 3.12.3 |
Contributor
Author
|
With the new logic, i.e. check for the numpy version, instead of the python version, the following works: Python 3.12.3 |
Member
|
This was replaced by #2809 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the String class, check for Python version when using npbytes and npunicode
Fixes #2807