Skip to content

Issues with Romberg integration in colors module #940

@rhdtownsend

Description

@rhdtownsend

There appear to be duplicate implementations of Romberg integration in the colors module -- one in colors_utils.f90, and the other in support_funcs.f90. I'm guessing that this isn't intentional?

Also, both of these duplicates use a Romberg algorithm that assumes uniformly spaced abscissae; however, given that an array of abscissa values is passed into the routines (in the x array), this algorithm is inappropriate, and will give incorrect results when x is non-uniform.

Metadata

Metadata

Labels

colorscolors moduleinvalidThis doesn't seem right

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions