Skip to content

adjust documentation on momentum outer BC#971

Closed
Debraheem wants to merge 1 commit intomainfrom
EbF/docs_momentum_BC
Closed

adjust documentation on momentum outer BC#971
Debraheem wants to merge 1 commit intomainfrom
EbF/docs_momentum_BC

Conversation

@Debraheem
Copy link
Copy Markdown
Member

Abha Vishwakarma made a mailinglist post highlighting this comment in the MESA documentation which is incorrect/outdated. I've amended the docs here.

@Debraheem Debraheem added the documentation Improvements or additions to documentation label Apr 18, 2026
@Debraheem Debraheem changed the title [ci skip] adjust documentation on momentum outer BC adjust documentation on momentum outer BC Apr 18, 2026
@VincentVanlaer
Copy link
Copy Markdown
Member

This may be a silly questions, but what is used for then?

@Debraheem
Copy link
Copy Markdown
Member Author

Debraheem commented Apr 18, 2026

That is not a silly question, in fact, it does appear completely deprecated. It doesn't look to be used by anything at the moment, except for it's own bookkeeping, but we should double check.

However, I'm trying to decide if it makes sense to bring back the BB outer bc, as it might be useful for a variety of things (such as ppisn), but i'm unsure. Maybe you have an opinion here?

@VincentVanlaer
Copy link
Copy Markdown
Member

Unless you want to add the BB boundary condition in the next few weeks, I would just remove it. Then we don't forget about it if we end up not adding that boundary condition.

@Debraheem
Copy link
Copy Markdown
Member Author

I think I'll just remove it unless someone objects. Less clutter.

@Debraheem Debraheem closed this Apr 18, 2026
@Debraheem Debraheem deleted the EbF/docs_momentum_BC branch April 18, 2026 20:07
@Debraheem Debraheem mentioned this pull request Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants