Closed
Conversation
Member
|
This may be a silly questions, but what is used for then? |
Member
Author
|
That is not a silly question, in fact, it does appear completely deprecated. It doesn't look to be used by anything at the moment, except for it's own bookkeeping, but we should double check. However, I'm trying to decide if it makes sense to bring back the BB outer bc, as it might be useful for a variety of things (such as ppisn), but i'm unsure. Maybe you have an opinion here? |
Member
|
Unless you want to add the BB boundary condition in the next few weeks, I would just remove it. Then we don't forget about it if we end up not adding that boundary condition. |
Member
Author
|
I think I'll just remove it unless someone objects. Less clutter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abha Vishwakarma made a mailinglist post highlighting this comment in the MESA documentation which is incorrect/outdated. I've amended the docs here.