Skip to content

fix: Add missing intent attributes to subroutine arguments #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Add missing intent attributes to subroutine arguments #1023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96de0d6
fix: Add missing intent attributes to subroutine arguments
sbryngelson Nov 4, 2025
f50c642
Merge branch 'master' into fortran-lint-fixes
sbryngelson Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .typos.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Strang = "Strang"
TKE = "TKE"
HSA = "HSA"
infp = "infp"
Sur = "Sur"

[files]
extend-exclude = ["docs/documentation/references*", "tests/", "toolchain/cce_simulation_workgroup_256.sh"]
4 changes: 2 additions & 2 deletions src/pre_process/m_boundary_conditions.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,8 @@ contains

impure subroutine s_apply_boundary_patches(q_prim_vf, bc_type)

type(scalar_field), dimension(sys_size) :: q_prim_vf
type(integer_field), dimension(1:num_dims, -1:1) :: bc_type
type(scalar_field), dimension(sys_size), intent(inout) :: q_prim_vf
Copy link

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter q_prim_vf is declared with intent(inout) but is never used or modified in the subroutine body. Based on the subroutine implementation (lines 237-261), only bc_type is passed to helper subroutines (s_circle_bc, s_rectangle_bc, s_line_segment_bc). This parameter should be declared with intent(in) instead, or removed entirely if not needed.

Copilot uses AI. Check for mistakes.
type(integer_field), dimension(1:num_dims, -1:1), intent(inout) :: bc_type
integer :: i

!< Apply 2D patches to 3D domain
Expand Down
Loading