Skip to content

Bug fix for CFL adaptive time stepping #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bug fix for CFL adaptive time stepping #1027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/simulation/m_sim_helpers.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,17 +271,17 @@ contains
if (grid_geometry == 3) then
fltr_dtheta = f_compute_filtered_dtheta(k, l)
vcfl_dt = cfl_target*(min(dx(j), dy(k), fltr_dtheta)**2._wp) &
/minval(1/(rho*Re_l))
/maxval(1/(rho*Re_l))
Comment on lines 273 to +274
Copy link
Contributor

@qodo-merge-pro qodo-merge-pro bot Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Prevent a potential division-by-zero error by adding a small epsilon value to the denominator rho*Re_l inside the maxval function call. [possible issue, importance: 8]

Suggested change
vcfl_dt = cfl_target*(min(dx(j), dy(k), fltr_dtheta)**2._wp) &
/minval(1/(rho*Re_l))
/maxval(1/(rho*Re_l))
vcfl_dt = cfl_target*(min(dx(j), dy(k), fltr_dtheta)**2._wp) &
/maxval(1/(rho*Re_l + epsilon(0.0_wp)))

else
vcfl_dt = cfl_target*(min(dx(j), dy(k), dz(l))**2._wp) &
/minval(1/(rho*Re_l))
/maxval(1/(rho*Re_l))
end if
elseif (n > 0) then
!2D
vcfl_dt = cfl_target*(min(dx(j), dy(k))**2._wp)/maxval((1/Re_l)/rho)
else
!1D
vcfl_dt = cfl_target*(dx(j)**2._wp)/minval(1/(rho*Re_l))
vcfl_dt = cfl_target*(dx(j)**2._wp)/maxval(1/(rho*Re_l))
end if
end if

Expand Down
Loading